Skip to content

Fix site sort order not preserved across app restarts #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcotrim merged 1 commit into from
Mar 25, 2026
Merged

Fix site sort order not preserved across app restarts #2902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/studio/src/hooks/use-site-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export function SiteDetailsProvider( { children }: SiteDetailsProviderProps ) {
async ( id: string, removeLocal: boolean ) => {
await deleteSite( id, removeLocal );
const newSites = await getIpcApi().getSiteDetails();
setSites( newSites );
setSites( sortSites( newSites ) );
// Use functional update to access current selectedSiteId value
// Tab reset is handled in SiteContentTabs when it detects the previous site was deleted
setSelectedSiteId( ( currentSelectedId ) => {
Expand Down Expand Up @@ -403,7 +403,7 @@ export function SiteDetailsProvider( { children }: SiteDetailsProviderProps ) {
const updateSite = useCallback( async ( site: SiteDetails, wpVersion?: string ) => {
await getIpcApi().updateSite( site, wpVersion );
const updatedSites = await getIpcApi().getSiteDetails();
setSites( updatedSites );
setSites( sortSites( updatedSites ) );
}, [] );

const saveTimeoutRef = useRef< ReturnType< typeof setTimeout > >();
Expand Down Expand Up @@ -581,7 +581,7 @@ export function SiteDetailsProvider( { children }: SiteDetailsProviderProps ) {
.getSiteDetails()
.then( async ( data ) => {
if ( ! cancel ) {
setSites( data );
setSites( sortSites( data ) );
setLoadingSites( false );
const autoStartSites = data.filter( ( site ) => site.autoStart );
void Promise.all( autoStartSites.map( ( site ) => startServer( site ) ) );
Expand Down
Loading