Fix account settings button opening general tab instead of account - #2930
Merged
Conversation
The Howdy/avatar button was calling showUserSettings() with no arguments,
causing TabPanel to default to the first tab ('general') after the tabs
were renamed. Pass 'account' explicitly to open the correct tab.
Collaborator
📊 Performance Test ResultsComparing 2f6c271 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
bcotrim
approved these changes
Mar 27, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Screen.Recording.2026-03-27.at.10.01.23.mov
katinthehatsite
approved these changes
Mar 27, 2026
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
These changes also look good to me 👍
11 tasks
fredrikekelund
pushed a commit
that referenced
this pull request
Apr 2, 2026
#2930) The Howdy/avatar button was calling showUserSettings() with no arguments, causing TabPanel to default to the first tab ('general') after the tabs were renamed. Pass 'account' explicitly to open the correct tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I used AI to fix the issue.
Proposed Changes
I propose to pass
'account'explicitly toshowUserSettings()in the top bar's authenticated user button. It seems as regression introduced at some point.Testing Instructions
Pre-merge Checklist