-
Notifications
You must be signed in to change notification settings - Fork 86
macOS: Auto-install CLI to ~/.local/bin #2937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
67ac233
Refactor macOS CLI installation to use ~/.local/bin
ivan-ottinger 314afbd
Respect user preference when CLI is explicitly disabled
ivan-ottinger d03e18f
Fix test paths for cross-platform CI compatibility
ivan-ottinger 8b7186a
Skip macOS-specific tests on Windows CI
ivan-ottinger 20e9dae
Remove legacy symlink cleanup
ivan-ottinger 9f5f263
Skip CLI auto-install in development mode
ivan-ottinger e78e351
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger 270df7f
Remove stale legacy cleanup comment from test
ivan-ottinger bf34da1
Fix uninstall ENOENT and narrow test skip to Windows only
ivan-ottinger 514943d
Remove redundant isCliInstalled check from autoInstallIfNeeded
ivan-ottinger 5eb12ec
Check PATH in isCliInstalled and normalize PATH entries
ivan-ottinger 816d532
Use process.env.SHELL for shell profile detection
ivan-ottinger 1f5f619
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger 54f7759
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger 5a0bc63
Check profile file instead of runtime PATH for CLI status
ivan-ottinger ec95c5a
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger be0d28a
Remove stale PATH setup from test beforeEach
ivan-ottinger 3f4fdb3
Simplify test mocks for readFile
ivan-ottinger 74cb728
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger 7e5f09e
Only treat ENOENT as empty profile, rethrow other errors
ivan-ottinger 645ba1f
Only set cliAutoInstalled flag after verifying install succeeded
ivan-ottinger 1ee857d
Revert isCliInstalled check after install on macOS
ivan-ottinger bf746d8
Merge branch 'trunk' into stu-1363-auto-install-cli-macos
fredrikekelund 520af96
Tweaks
fredrikekelund 681f640
Clean up legacy CLI symlink when uninstalling, if needed
fredrikekelund 820334c
Simplification
fredrikekelund 5fc4568
Move functions to methods
fredrikekelund 9339dfa
`os.userInfo()` and shell basenames instead of paths
fredrikekelund 1270007
Minor tweak
fredrikekelund fb6f9dc
Remove "CLI Installed" modal
fredrikekelund File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Only treat ENOENT as empty profile, rethrow other errors
Prevents silently overwriting the user's shell profile if readFile fails for a reason other than the file not existing (e.g. permissions or I/O errors).
- Loading branch information
commit 7e5f09ea0a460b20e6bedfd324ca3ef07ec32da7
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.