Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
67ac233
Refactor macOS CLI installation to use ~/.local/bin
ivan-ottinger Mar 27, 2026
314afbd
Respect user preference when CLI is explicitly disabled
ivan-ottinger Mar 27, 2026
d03e18f
Fix test paths for cross-platform CI compatibility
ivan-ottinger Mar 27, 2026
8b7186a
Skip macOS-specific tests on Windows CI
ivan-ottinger Mar 27, 2026
20e9dae
Remove legacy symlink cleanup
ivan-ottinger Mar 27, 2026
9f5f263
Skip CLI auto-install in development mode
ivan-ottinger Mar 27, 2026
e78e351
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger Mar 27, 2026
270df7f
Remove stale legacy cleanup comment from test
ivan-ottinger Mar 27, 2026
bf34da1
Fix uninstall ENOENT and narrow test skip to Windows only
ivan-ottinger Mar 27, 2026
514943d
Remove redundant isCliInstalled check from autoInstallIfNeeded
ivan-ottinger Apr 1, 2026
5eb12ec
Check PATH in isCliInstalled and normalize PATH entries
ivan-ottinger Apr 1, 2026
816d532
Use process.env.SHELL for shell profile detection
ivan-ottinger Apr 1, 2026
1f5f619
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger Apr 1, 2026
54f7759
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger Apr 2, 2026
5a0bc63
Check profile file instead of runtime PATH for CLI status
ivan-ottinger Apr 2, 2026
ec95c5a
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger Apr 2, 2026
be0d28a
Remove stale PATH setup from test beforeEach
ivan-ottinger Apr 2, 2026
3f4fdb3
Simplify test mocks for readFile
ivan-ottinger Apr 2, 2026
74cb728
Merge remote-tracking branch 'origin/trunk' into stu-1363-auto-instal…
ivan-ottinger Apr 2, 2026
7e5f09e
Only treat ENOENT as empty profile, rethrow other errors
ivan-ottinger Apr 2, 2026
645ba1f
Only set cliAutoInstalled flag after verifying install succeeded
ivan-ottinger Apr 2, 2026
1ee857d
Revert isCliInstalled check after install on macOS
ivan-ottinger Apr 2, 2026
bf746d8
Merge branch 'trunk' into stu-1363-auto-install-cli-macos
fredrikekelund Apr 8, 2026
520af96
Tweaks
fredrikekelund Apr 8, 2026
681f640
Clean up legacy CLI symlink when uninstalling, if needed
fredrikekelund Apr 8, 2026
820334c
Simplification
fredrikekelund Apr 8, 2026
5fc4568
Move functions to methods
fredrikekelund Apr 8, 2026
9339dfa
`os.userInfo()` and shell basenames instead of paths
fredrikekelund Apr 8, 2026
1270007
Minor tweak
fredrikekelund Apr 8, 2026
fb6f9dc
Remove "CLI Installed" modal
fredrikekelund Apr 8, 2026
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only treat ENOENT as empty profile, rethrow other errors
Prevents silently overwriting the user's shell profile if readFile
fails for a reason other than the file not existing (e.g. permissions
or I/O errors).
  • Loading branch information
ivan-ottinger committed Apr 2, 2026
commit 7e5f09ea0a460b20e6bedfd324ca3ef07ec32da7
7 changes: 5 additions & 2 deletions apps/studio/src/modules/cli/lib/macos-installation-manager.ts
Comment thread
ivan-ottinger marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@ function getProfilePath(): string {
async function readProfileContent(): Promise< string > {
try {
return await readFile( getProfilePath(), 'utf-8' );
} catch {
return '';
} catch ( error ) {
if ( isErrnoException( error ) && error.code === 'ENOENT' ) {
return '';
}
throw error;
}
}

Expand Down
Loading