Skip to content

Studio: New site form can be submitted with incorrect values using enter key #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 5 commits into from
Apr 7, 2026
Merged

Studio: New site form can be submitted with incorrect values using enter key #2959

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2efcb9c
Ensure we don't submit form that has empty site name
Apr 1, 2026
e3ec275
Merge branch 'trunk' of github.com:Automattic/studio into fix/site-va…
Apr 2, 2026
f3a5554
Solve for sitename errors
Apr 2, 2026
d33f4f0
Linter fix
Apr 2, 2026
33d3d55
Merge branch 'trunk' into fix/site-validation-errors-form
katinthehatsite Apr 2, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions apps/studio/src/modules/add-site/components/create-site-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ export const CreateSiteForm = ( {
}

const hasErrors =
! siteName.trim() ||
!! pathError ||
( useCustomDomain && !! customDomainError ) ||
! adminUsername.trim() ||
Expand All @@ -306,7 +307,15 @@ export const CreateSiteForm = ( {
onValidityChange( isValid );
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [ pathError, customDomainError, useCustomDomain, adminUsername, adminPassword, adminEmail ] );
}, [
siteName,
pathError,
customDomainError,
useCustomDomain,
adminUsername,
adminPassword,
adminEmail,
] );

const handleSiteNameChange = useCallback(
async ( name: string ) => {
Expand Down Expand Up @@ -455,7 +464,9 @@ export const CreateSiteForm = ( {
onKeyDown={ ( event ) => {
if ( event.key === 'Enter' ) {
event.preventDefault();
handleFormSubmit( event as FormEvent );
if ( errorCount === 0 ) {
handleFormSubmit( event as FormEvent );
}
}
} }
data-testid="site-name-input"
Expand Down
Loading