Skip to content

Dark mode: fix Learn more link color inside Sync dialog - #2966

Merged
nightnei merged 1 commit into
trunkfrom
fixLearnmoreColorLinkInSyncDialog
Apr 6, 2026
Merged

Dark mode: fix Learn more link color inside Sync dialog#2966
nightnei merged 1 commit into
trunkfrom
fixLearnmoreColorLinkInSyncDialog

Conversation

@nightnei

@nightnei nightnei commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

Learn more link is highlighted in Light mode:
Screenshot 2026-04-02 at 18 04 26

But in Dark mode it's almost not noticable:
Screenshot 2026-04-02 at 18 04 37

I think it makes sense to highlight it, according to the styles for Light mode and "Create a new WordPres.com site" link

Testing Instructions

  1. Set Dark mode
  2. Open Sync dialog
  3. Assert that you see the same color for Learn more link as for "Create a new WordPres.com site" link
    Screenshot 2026-04-02 at 18 05 44
@nightnei
nightnei requested a review from a team April 2, 2026 17:06
@nightnei nightnei self-assigned this Apr 2, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 8d7a1d9 vs trunk

app-size

Metric trunk 8d7a1d9 Diff Change
App Size (Mac) 1271.61 MB 1271.61 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 8d7a1d9 Diff Change
load 1902 ms 1876 ms 26 ms ⚪ 0.0%

site-startup

Metric trunk 8d7a1d9 Diff Change
siteCreation 8168 ms 8180 ms +12 ms ⚪ 0.0%
siteStartup 4816 ms 4838 ms +22 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nightnei for fixing this! I have tested it, and I can see the proper color now. LGTM!

Before After
Image Image
@nightnei
nightnei merged commit 66103a2 into trunk Apr 6, 2026
10 checks passed
@nightnei
nightnei deleted the fixLearnmoreColorLinkInSyncDialog branch April 6, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants