Add multisite warning to push dialog for WordPress.com targets - #2991
Conversation
📊 Performance Test ResultsComparing 0f71438 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
| className="!p-0 !h-auto text-[12px] [&.is-link]:text-frame-text-secondary [&.is-link]:hover:text-frame-theme" | ||
| onClick={ () => setWarningsExpanded( ! warningsExpanded ) } | ||
| > | ||
| { warningsExpanded ? __( 'Hide' ) : __( 'Show' ) } |
katinthehatsite
left a comment
There was a problem hiding this comment.
Thanks for all the changes - I like that there is an option to hide the warnings so that they are not taking too much space. Should we slightly drop the space below the database when the modal is open?
I am also wondering - do you know if multisites could create unexpected issues for the preview sites?
|
Another question that I forgot to add to the review: I am currently seeing that when you open the modal, it shows by default the warnings and then you can hide them. Should we hide them by default so that they don't initially take too much space and then the user can open the later? |
|
Thanks for the review @katinthehatsite
It was intentional, since it could be an operation that breaks the production site, I think having them open by default increases the chance our users won't miss it. |
I don't have a strong opinion as I can see the benefits either way. I will give it another review 👀 |
katinthehatsite
left a comment
There was a problem hiding this comment.
I have retested it and I think it looks and works better. Also thanks for adding it to the preview sites 👍
I am not sure what is the expected design for this though. It might be worth confirming this with design. On my side, I don't have any further comments



Related issues
How AI was used in this PR
Implementation was AI-assisted. All code was reviewed and iterated on manually.
Proposed Changes
wp-config.phpfor theMULTISITEconstantgetIsMultisiteIPC handler anduseIsMultisiteReact hook (same pattern asgetWpVersion/useGetWpVersion)Testing Instructions
"step": "enableMultisite"to create a multisite sitenpm test -- tools/common/lib/tests/is-multisite.test.ts— all 7 tests passPre-merge Checklist