Skip to content

Fix copy for php and wp version mismatch - #3001

Merged
nightnei merged 1 commit into
trunkfrom
fixCopyForPhpVersionMismatch
Apr 7, 2026
Merged

Fix copy for php and wp version mismatch#3001
nightnei merged 1 commit into
trunkfrom
fixCopyForPhpVersionMismatch

Conversation

@nightnei

@nightnei nightnei commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

We should not mention wordpress.com in the version mismatch notice (Sync dialog), since it's used for both wpcom and Pressable.

The new notice:
Screenshot 2026-04-07 at 15 51 38

Testing Instructions

Visual review should suffice

@nightnei
nightnei requested a review from a team April 7, 2026 14:51
@nightnei nightnei self-assigned this Apr 7, 2026
<p data-testid="push-version-mismatch-notice">
{ __(
'Your Studio site is using a different WordPress or PHP version than your WordPress.com site. The remote site will keep on using the newest supported versions.'
'Your Studio site is using a different WordPress or PHP version than your remote site. The remote site will keep using the newest supported versions.'

@nightnei nightnei Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing "on" was recommended by AI, however, I find both options good.

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing bde82d9 vs trunk

app-size

Metric trunk bde82d9 Diff Change
App Size (Mac) 1249.53 MB 1249.53 MB 0.01 MB ⚪ 0.0%

site-editor

Metric trunk bde82d9 Diff Change
load 1907 ms 1881 ms 26 ms ⚪ 0.0%

site-startup

Metric trunk bde82d9 Diff Change
siteCreation 9183 ms 8206 ms 977 ms 🟢 -10.6%
siteStartup 4841 ms 4937 ms +96 ms 🔴 2.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@nightnei
nightnei merged commit aa2dad4 into trunk Apr 7, 2026
12 checks passed
@nightnei
nightnei deleted the fixCopyForPhpVersionMismatch branch April 7, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants