Skip to content

Fix dark mode scrollbar - #3003

Merged
bcotrim merged 1 commit into
trunkfrom
fix-dark-mode-scrollbar
Apr 8, 2026
Merged

Fix dark mode scrollbar#3003
bcotrim merged 1 commit into
trunkfrom
fix-dark-mode-scrollbar

Conversation

@bcotrim

@bcotrim bcotrim commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

AI identified the root cause and wrote the CSS fix. Changes were visually verified by the developer before/after.

Proposed Changes

Note

I wasn't able to replicate the issue mentioned in Linear, but I still improved the layout of the scrollbar.

  • Add color-scheme: dark to the dark mode media query so the browser renders native UI elements (scrollbars, form controls) with dark styling
  • Replace hardcoded color values in .sites-scrollbar with existing CSS custom properties (--color-frame-scrollbar-thumb, --color-frame-scrollbar-border, --color-frame-scrollbar-thumb-hover) for consistency with other scrollbar styles
trunk now
image image

Testing Instructions

  • Switch Studio to dark mode (Settings > Appearance > Dark, or set macOS to dark mode with Studio on "System")
  • Navigate to the Settings tab for any site
  • Resize the window to trigger scrollbars
  • Verify scrollbars match the dark theme (no white background)
  • Also check the sidebar site list scrollbar and any modals with scrollable content

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim bcotrim self-assigned this Apr 7, 2026
@bcotrim
bcotrim requested a review from a team April 7, 2026 16:46
@bcotrim bcotrim changed the title Fix dark mode white scrollbar Apr 7, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing e581556 vs trunk

app-size

Metric trunk e581556 Diff Change
App Size (Mac) 1249.54 MB 1249.54 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk e581556 Diff Change
load 1931 ms 1942 ms +11 ms ⚪ 0.0%

site-startup

Metric trunk e581556 Diff Change
siteCreation 8188 ms 8186 ms 2 ms ⚪ 0.0%
siteStartup 4833 ms 4843 ms +10 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcotrim for improving this! I have tested it, and I can confirm that the scrollbars colors are better now. LGTM!

Screen Before After
Settings Image Image
Connect sites modal Image Image
@bcotrim
bcotrim merged commit 4563a83 into trunk Apr 8, 2026
11 of 12 checks passed
@bcotrim
bcotrim deleted the fix-dark-mode-scrollbar branch April 8, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants