Fix locale data type annotation to resolve TS7056 serialization error - #3040
Closed
sejas wants to merge 1 commit into
Closed
Fix locale data type annotation to resolve TS7056 serialization error#3040sejas wants to merge 1 commit into
sejas wants to merge 1 commit into
Conversation
node exceeds the maximum length the compiler will serialize. An explicit type annotation is needed. (ts 7056)
Member
Author
|
Closing this PR as it will be merged in the beta backmerge #3041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
tools/common/translations/index.tsHow AI was used in this PR
Claude suggested the fix approach (explicit type annotation with
SupportedLocaleunion type). The implementation was reviewed and verified withnpm run typecheck.Proposed Changes
LocaleDatatype matching the JED JSON structure ({ messages: Record<...> })SupportedLocaleunion type for all supported locale keyslocaleDataDictionarywithRecord<SupportedLocale, LocaleData | null>instead of relying onas constinferenceas constassertion that caused TypeScript to serialize the entire translation literal typesTesting Instructions
npm run typecheck— should pass with no errorsnpm start, change language in settings, confirm UI strings updatePre-merge Checklist