Update --json mode exit handling, type safety, and adapter consistency - #3081
Merged
sejas merged 1 commit intoApr 14, 2026
Merged
Conversation
…and adapter consistency - Replace process.exit() with process.exitCode in JSON mode to let the event loop drain naturally, ensuring stdout flushes and async persistence completes before the process terminates - Use discriminated union (type field) for HandleMessageResult instead of optional undefined trick - Make showProgress emit progress events consistently with setLoaderMessage - Add runtime guard for AiChatUI instanceof check instead of unsafe type cast Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
sejas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
--jsonflag for headless NDJSON output #3012 (CLI AI: Add--jsonflag for headless NDJSON output)Proposed Changes
process.exit()withprocess.exitCodein JSON mode single-turn path andJsonAdapter.askUser()so the event loop drains naturally — stdout flushes and async session persistence completes before the process terminatesHandleMessageResultfrom a fragile optional-undefined union to a proper discriminated union with atypefield ('result' | 'max_turns')JsonAdapter.showProgress()emitprogressNDJSON events consistently withsetLoaderMessage()instead of silently discarding inputui as AiChatUIcast with a runtimeinstanceofguard that throws a clear error if the adapter isn'tAiChatUITesting Instructions
npm run cli:buildnode apps/cli/dist/cli/main.mjs code "hello" --jsonnpm test -- apps/cli/commands/ai/tests/ai.test.tsPre-merge Checklist