Skip to content

Stop runtime update checks for WP-CLI and sqlite-command - #3086

Merged
bcotrim merged 1 commit into
trunkfrom
stu-1549-stop-runtime-update-checks
Apr 15, 2026
Merged

Stop runtime update checks for WP-CLI and sqlite-command#3086
bcotrim merged 1 commit into
trunkfrom
stu-1549-stop-runtime-update-checks

Conversation

@bcotrim

@bcotrim bcotrim commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

AI-assisted implementation: code changes were reviewed and validated by the author.

Proposed Changes

  • Remove runtime update checks for WP-CLI and wp-cli-sqlite-command from updateServerFiles()
  • Delete wp-cli.ts and sqlite-command.ts dependency management modules
  • Remove now-unused fetchLatestGithubRelease() utility and its zod schema from utils.ts
  • Keep WordPress version update check in updateServerFiles() as it remains needed

These dependencies (WP-CLI, sqlite-database-integration, wp-cli-sqlite-command) are tightly coupled — if one assumes a specific version of another, runtime updates risk breaking the app. They are now shipped as fixed, bundled versions only (via setupServerFiles()).

Testing Instructions

  • Run npm run typecheck — should pass with no errors
  • Run npm test -- apps/cli/commands/site/tests/create.test.ts — all 46 tests should pass
  • Create a new site via CLI (npm run cli:build && node apps/cli/dist/cli/main.mjs site create ~/Studio/test-site) — should still check for WordPress updates but no longer check for WP-CLI or sqlite-command updates
  • Verify bundled dependencies still get copied on setup (WP-CLI phar, sqlite-command directory)

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim bcotrim self-assigned this Apr 14, 2026
@bcotrim
bcotrim requested review from a team and fredrikekelund April 14, 2026 11:39
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing ccc681e vs trunk

app-size

Metric trunk ccc681e Diff Change
App Size (Mac) 1286.17 MB 1286.16 MB 0.01 MB ⚪ 0.0%

site-editor

Metric trunk ccc681e Diff Change
load 1866 ms 1902 ms +36 ms ⚪ 0.0%

site-startup

Metric trunk ccc681e Diff Change
siteCreation 9136 ms 8105 ms 1031 ms 🟢 -11.3%
siteStartup 4948 ms 4959 ms +11 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@fredrikekelund fredrikekelund left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple change 👍 I haven't tested, but I trust the E2E tests to show that the fundamentals still work as expected.

@fredrikekelund

Copy link
Copy Markdown
Contributor

We could maybe fold STU-1455 into this PR… I don't think that's a must-have, given that we only check for updates to a single dependency now, but it's also a really simple change and does improve bottom-line efficiency.

@bcotrim

bcotrim commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

We could maybe fold STU-1455 into this PR… I don't think that's a must-have, given that we only check for updates to a single dependency now, but it's also a really simple change and does improve bottom-line efficiency.

Since is already done and approved let's ship it. I'll follow-up with the change for STU-1455 so we release them together in the next Studio version.

@bcotrim
bcotrim merged commit a97ef22 into trunk Apr 15, 2026
10 checks passed
@bcotrim
bcotrim deleted the stu-1549-stop-runtime-update-checks branch April 15, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants