Update SQLite Database Integration to v3.0.0-rc.1 - #3172
Merged
Conversation
…E_AST_DRIVER flag
Collaborator
📊 Performance Test ResultsComparing 81e21a4 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
|
Thanks @sejas ! The But it uncovers another issue - when Studio copies the SQLite plugin to the site directory, it doesn't remove the existing files, so after each update, the directory contains not only new files, but old ones, too. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
How AI was used in this PR
Claude Code identified and applied all changes.
Proposed Changes
SQLITE_DATABASE_INTEGRATION_VERSIONfromv2.2.23tov3.0.0-rc.1WP_SQLITE_AST_DRIVER: truefromdefaultConstantsinwordpress-server-child.tsphp.defineConstant('WP_SQLITE_AST_DRIVER', true)fromrun-wp-cli-command.tsDB_NAME: 'wordpress'at runtime in bothwordpress-server-child.tsandrun-wp-cli-command.tsThe
WP_SQLITE_AST_DRIVERconstant was a feature flag enabling the new AST-based driver in earlier versions. Starting with v3.0.0, the old driver has been removed and the flag is no longer needed.SQLite v3.0.0 also removed the fallback for a missing
DB_NAME— it now requires a non-empty value at runtime or it bails with "Error establishing a database connection". Studio strips the default MySQL constants (includingDB_NAME) fromwp-config.phpafter site creation, which previously worked because v2 had a'database_name_here'fallback. We fix this by explicitly definingDB_NAME: 'wordpress'as a runtime constant (the same value Playground'sensureWpConfigwould set), so sites whereDB_NAMEwas stripped still work correctly.Testing Instructions
wp option get siteurl) and confirm it worksPre-merge Checklist