apps/ui: migrate to @wordpress/theme 0.11 token names - #3231
Merged
Conversation
The 0.11 release renamed a large number of design tokens and the postcss plugin now throws on any unknown token. Update every CSS reference in apps/ui/src to the new names, preserving visual intent by matching fallback values in design-token-fallbacks.mjs where the mapping was ambiguous. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 05a9f17 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
@wordpress/themefrom 0.10.0 to 0.11.0)How AI was used in this PR
Claude Code performed the migration. For each stale token, I cross-referenced the new token list in
node_modules/@wordpress/theme/build-module/prebuilt/js/design-tokens.mjsand the fallback values indesign-token-fallbacks.mjs, matching visual intent rather than doing blind string replacement. Ambiguous tokens (--wpds-color-border,--wpds-color-text,--wpds-color-surface-hover, etc.) were mapped by comparing the old fallback values in-context to the new fallback values and picking the token that best matched the original intent.Proposed Changes
The 0.11 release of
@wordpress/themerenamed a large number of design tokens. Its postcss plugin (postcss-ds-token-fallbacks) now throwsUnknown design tokenon any unrecognized name, sonpm starthard-fails until every reference is migrated.This PR migrates every
var(--wpds-*)reference inapps/ui/src/**/*.cssto the new names. It is a pure CSS migration — no JS/TS files or configuration are touched.Mechanical renames (apply uniformly to every size/variant suffix):
--wpds-font-size-*--wpds-typography-font-size-*--wpds-font-family-*--wpds-typography-font-family-*--wpds-font-line-height-*--wpds-typography-line-height-*--wpds-font-weight-*--wpds-typography-font-weight-*--wpds-dimension-radius-*--wpds-border-radius-*--wpds-shadow-elevation-md--wpds-elevation-md--wpds-color-fg-content-critical--wpds-color-fg-content-error--wpds-color-stroke-neutral-weak--wpds-color-stroke-surface-neutral-weak--wpds-color-bg-surface-strong--wpds-color-bg-surface-neutral-strongAmbiguous renames (resolved by matching the old fallback value and usage intent):
--wpds-color-border(#ccc/#ddd)--wpds-color-stroke-surface-neutral(#dbdbdb)--wpds-color-border-hover(#888/#bbb)--wpds-color-stroke-interactive-neutral(#8d8d8d)--wpds-color-surface(#fff)--wpds-color-bg-surface-neutral-strong(#ffffff)--wpds-color-surface-hover(#f7f7f7)--wpds-color-bg-interactive-neutral-weak-active(#ededed)--wpds-color-bg-surface-neutral-hover--wpds-color-bg-interactive-neutral-weak-active(#ededed)--wpds-color-text(#1e1e1e)--wpds-color-fg-content-neutral(#1e1e1e)--wpds-color-text-secondary(#555/#666)--wpds-color-fg-content-neutral-weak(#707070)--wpds-color-text-link(#0075ff)--wpds-color-fg-interactive-brand(admin theme color)--wpds-color-fg-content-accent(#2563eb)--wpds-color-fg-interactive-brand(admin theme color)25 files changed in
apps/ui/src.Testing Instructions
npm startlaunches without any[postcss] Unknown design token: ...errors.--wpds-color-bg-surface-strong→--wpds-color-bg-surface-neutral-strong).Pre-merge Checklist
Verified locally:
npm run build -w @studio/uiproduceddist/assets/index-Cho0-sdX.css(223KB) without postcss errors — this runs the samedsTokenFallbacksPostcssplugin the dev server uses.npm run typecheckpasses.npx eslint --fixon the changed files is a no-op (CSS is not linted).🤖 Generated with Claude Code