-
Notifications
You must be signed in to change notification settings - Fork 86
Fix Studio app metadata for Linux software stores #3335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f0f6a9e
577c9a3
b79f8fe
02f0619
5bdad85
618ca05
a5728af
2ed197e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,7 +6,9 @@ | |||||||
| Icon=<%= name %> | ||||||||
| <% } %>Type=Application | ||||||||
| StartupNotify=true | ||||||||
| StartupWMClass=<%= productName %> | ||||||||
| # Must match Electron's runtime WMClass (derived from app.getName(), i.e. package.json.name). | ||||||||
| # Don't template from productName — the launcher icon won't group with the running window. | ||||||||
| StartupWMClass=Studio | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if we added a short comment like this one? Just to ensure this won't get changed accidentally in the future:
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea — pushed the comment on the branch. One small tweak to the wording: the value needs to match Electron's runtime WMClass (derived from Final form: |
||||||||
| <% if (categories && categories.length) { %>Categories=<%= categories.join(';') %>; | ||||||||
| <% } %><% if (mimeType && mimeType.length) { %>MimeType=<%= mimeType.join(';') %>; | ||||||||
| <% } %> | ||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that
productNameisWordPress Studio, should this open with "Meet WordPress Studio" for consistency with the launcher/store name? The counter-argument is keeping it verbatim with the Microsoft Store copy. No strong opinion — what do you think? cc @ivan-ottingerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I think for now we could keep
Meet Studio - a fast, free way to develop locally with WordPress.- since otherwise we would haveWordPressmentioned two times there:Meet WordPress Studio - a fast, free way to develop locally with WordPress.We could later decide to improve the description and change it on both Microsoft Store and App Center at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense — the doubled "WordPress" would read awkwardly. Happy to keep it as
Meet Studio …and revisit alongside the MS Store copy when we next touch it. Thanks!