Skip to content

Fix .deb policykit dependency for Debian trixie / Kali - #3364

Merged
gavande1 merged 5 commits into
trunkfrom
rsm-2433-fix-policykit-deb-dependency
May 11, 2026
Merged

Fix .deb policykit dependency for Debian trixie / Kali#3364
gavande1 merged 5 commits into
trunkfrom
rsm-2433-fix-policykit-deb-dependency

Conversation

@gavande1

@gavande1 gavande1 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Claude Code applied the one-line dependency change proposed in the Linear issue and rewrote the inline comment to explain why the alternative is needed. I verified the build install on both Ubuntu 24.04 and Kali myself.

Proposed Changes

  • Switch the .deb Depends entry from policykit-1 to pkexec | policykit-1 so the package resolves on both legacy (Ubuntu 24.04 / older Debian) and current (Debian trixie / Kali rolling) polkit packaging. Both alternatives ultimately provide the pkexec binary that @vscode/sudo-prompt needs for hosts-file writes.
  • Update the inline comment in apps/studio/forge.config.ts to document the split and why the alternative is required.

Testing Instructions

  1. Build the .deb: npm run make on Linux.
  2. Install on Ubuntu 24.04: sudo apt install ./out/make/deb/**/studio_*.deb — should resolve policykit-1 and install cleanly. ✅ Verified.
  3. Install on Kali Linux (and/or Debian trixie): same command — should now resolve pkexec and install cleanly (previously failed with Depends: policykit-1 but it is not installable). ✅ Verified.
  4. On each, run the Trust Certificate flow — the polkit prompt should appear and the system-bundle install should succeed.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@gavande1
gavande1 requested review from a team and ivan-ottinger May 6, 2026 16:38
@wpmobilebot

wpmobilebot commented May 6, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing e3e3b27 vs trunk

app-size

Metric trunk e3e3b27 Diff Change
App Size (Mac) 1408.82 MB 1408.82 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk e3e3b27 Diff Change
load 1507 ms 1478 ms 29 ms ⚪ 0.0%

site-startup

Metric trunk e3e3b27 Diff Change
siteCreation 8088 ms 8086 ms 2 ms ⚪ 0.0%
siteStartup 4942 ms 4931 ms 11 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@ivan-ottinger ivan-ottinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The change looks good! I am currently building the app and will test it, but already approving the PR as I don't think there will be any issues.

@gavande1
gavande1 merged commit 967a30f into trunk May 11, 2026
10 checks passed
@gavande1
gavande1 deleted the rsm-2433-fix-policykit-deb-dependency branch May 11, 2026 10:17
@ivan-ottinger

Copy link
Copy Markdown
Contributor

Just noting that the fix is working well:

Before:

CleanShot 2026-05-11 at 12 22 40@2x

After:

CleanShot 2026-05-11 at 12 23 19@2x CleanShot 2026-05-11 at 12 26 55@2x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants