Update delete site modal to delete files by default - #352
Merged
Conversation
katinthehatsite
approved these changes
Jul 11, 2024
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes look clear and work as expected on my end:
Contributor
|
Can we tweak the description copy so that it flows a bit better:
|
Contributor
Author
|
@matt-west sure, but let's handle that under separate PR. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #303
Proposed Changes
I propose to change the delete site modal to automatically check the option to delete site's files.
Testing Instructions
Then test the opposite, so after unchecking option, site's files should stay.
Pre-merge Checklist