Open restart nudge if user triggers update check after closing it - #353
Merged
Conversation
Contributor
|
I tested this against the flow on trunk and I think the user experience is better with this implementation. |
katinthehatsite
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #277
Proposed Changes
When there is a new Studio version, Studio asks if user wants to upgrade. If they choose 'Later', and then try using 'Check for Updates' option, nothing will happen.
I propose to add a restart nudge in such a case to ensure that users get feedback when they use 'Check for Updates' again.
Testing Instructions
npm startPre-merge Checklist