More resilient error handling in SymlinkWatcher - #3533
Merged
Conversation
fredrikekelund
marked this pull request as ready for review
May 20, 2026 09:20
Collaborator
📊 Performance Test ResultsComparing a6885ff vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude drove the implementation based on logs and error context that I gathered.
Proposed Changes
I had observed issues on Windows with the
SymlinkWatcheremitting uncaught exceptions on Windows when Studio was applying a blueprint to a site. This killed the site process, which obviously is a pretty bad experience for users. This PR fixes that by:persistent: trueto chokidar. Per the docs, this option has limited effect, but it also attaches anerrorlistener to the underlying FS watcher, which prevents Node from throwing uncaught exceptions.errorevents. On Windows, the theory is that this happens when thewp-contentdir itself is removed (or considered to have been removed by the kernel)Testing Instructions
npx cross-env STUDIO_RUNTIME=native-php npm startPre-merge Checklist