Demo Sites: Ensure demo site uses WP version same as local site

[sejas]

• Closes https://github.com/Automattic/dotcom-forge/issues/6635

Proposed Changes

• It sends the local WordPress version when a Demo site is created or updated to match the same wp version

Testing Instructions

• Apply and sandbox the API D146651-code
• Select any site
• Ideally change your local WordPress version to a different one. You can use wp core update --version=6.4.1 --force
• Click on Share tab
• Create a new demo site
• Wait until the process finishes
• Enter on /wp-admin on wp.build site
• Observe the WordPress version matches your local site

demo.sites.match.local.wordpress.site.mp4

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wojtekn]

The code change looks clean. I left two minor comments.

Could we send the WP version with the demo site update request, too?

[wojtekn]

Nitpick: the condition is clear enough, so we don't need the comment

[sejas]

Thanks for confirming it. I was not sure if it was clear enough.
I was thinking to make a comparison like, but I preferred to add it as a comment.
if ( wordpressVersion.length >= 'x.y'.length ) {

Anyway, if it's not clear for everybody, now they can read these comments 👍

Removed the comment: d58a3ac

[wojtekn]

Should we update

studio/src/preload.ts

Line 32 in 28aa115

getWpVersion: ( wordPressPath: string ) => ipcRenderer.invoke( 'getWpVersion', wordPressPath ),

as well?

[sejas]

Yes!, thanks for the early feedback.

Changed 691fa9a

[katinthehatsite]

I am testing the issue that this is what I am getting on my end (in combination with the backend diff):

I am not sure if it is because the code needs to be in production to confirm the WordPress version of the demo site or if I am testing something incorrectly on my end. If the code needs to be in production, what is the best way to confirm that the version is set up correctly on the demo site? Thanks!

[sejas]

@katinthehatsite, thanks for reviewing it!. The best way is running a query on our end. I updated the description on D146651-code, that seems it was overwritten with an old version.

[wojtekn]

I tested this with the server-side diff, and everything worked as expected.