Skip to content

Remove jetpack/subscriptions newsletter signup recommendation - #3619

Merged
lezama merged 1 commit into
trunkfrom
claude/fervent-darwin-0b88a1
May 26, 2026
Merged

Remove jetpack/subscriptions newsletter signup recommendation#3619
lezama merged 1 commit into
trunkfrom
claude/fervent-darwin-0b88a1

Conversation

@youknowriad

Copy link
Copy Markdown
Contributor

Related issues

  • Related to: agent-generated newsletter signup blocks rendering empty on Studio sites

How AI was used in this PR

Claude Code edited the agent's plugin-recommendations skill and the related routing references to drop the jetpack/subscriptions block recommendation. I reviewed the diff and confirmed the remaining Jetpack Forms section is unchanged.

Proposed Changes

Why

jetpack/subscriptions requires a Jetpack / WordPress.com connection to actually create subscribers. Local Studio sites don't have that connection by default, so when the agent generated newsletter signup markup, the block rendered as an empty form on the frontend. Removing the recommendation prevents that failure mode until we have a story for the connection step. Jetpack Forms (contact form) does not have the same requirement and stays in the skill.

Testing Instructions

  • npm test -- apps/cli/ai/tests/block-content-policy.test.ts apps/cli/ai/tests/system-prompt.test.ts — 11/11 pass.
  • Ask the agent for a "newsletter signup" or "email subscribe form" on a local site and confirm it no longer reaches for jetpack/subscriptions. The Jetpack Forms / contact-form path should still work for contact forms.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
The jetpack/subscriptions block requires a Jetpack/WordPress.com
connection to actually create subscribers, which Studio sites do
not have by default. Recommending it caused the agent to generate
markup that renders an empty form on the frontend.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@youknowriad
youknowriad requested a review from lezama May 26, 2026 11:46
@youknowriad youknowriad self-assigned this May 26, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing ebe4158 vs trunk

app-size

Metric trunk ebe4158 Diff Change
App Size (Mac) 1340.06 MB 1340.06 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk ebe4158 Diff Change
load 1747 ms 1762 ms +15 ms ⚪ 0.0%

site-startup

Metric trunk ebe4158 Diff Change
siteCreation 9590 ms 9588 ms 2 ms ⚪ 0.0%
siteStartup 4924 ms 4918 ms 6 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@lezama
lezama merged commit e07bbc0 into trunk May 26, 2026
4 checks passed
@lezama
lezama deleted the claude/fervent-darwin-0b88a1 branch May 26, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants