Skip to content

Studio: Replace button loading indicator with full window one #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 19 commits into from
Jul 17, 2024
Merged

Studio: Replace button loading indicator with full window one #362

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
79793c0
Add basic logic for a new site adding state
Jul 15, 2024
93818f0
Remove state that handles adding a site
Jul 15, 2024
218e36a
Close modal
Jul 15, 2024
631bb17
Add progress bar for loading
Jul 15, 2024
332acc4
Jump to a new site when it is created
Jul 15, 2024
8356362
Add sidebar spinner
Jul 15, 2024
fd411db
Add site name to the loading screen
Jul 15, 2024
5e67070
Throw error when creating a site fails
Jul 16, 2024
bc793c4
Add error handling and remove temporary state when error occurs
Jul 16, 2024
2ab04ce
Remove tests not necessary for the new flow
Jul 16, 2024
578491b
fix end to end tests
Jul 16, 2024
2f42293
Generate random ID for temptorary state
Jul 16, 2024
b3ba3b6
Remove adding site string from onboarding
Jul 17, 2024
31548b9
Remove adding site string from onboarding
Jul 17, 2024
566ef6f
Add bug fix and improve the UI flow
Jul 17, 2024
4bbe32d
Centralize error handling
Jul 17, 2024
d180b37
Disable the add site button when a site is being added
Jul 17, 2024
8fe0c6c
Remove busy states from onboarding add site button
Jul 17, 2024
d83fd0d
Make the progress bar more dynamic for faster visual effect
Jul 17, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove adding site string from onboarding
  • Loading branch information
Kateryna Kodonenko
Kateryna Kodonenko committed Jul 17, 2024
commit b3ba3b68fab99b59d92ddc71cdc209b9bb07f02a
2 changes: 1 addition & 1 deletion src/components/onboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export default function Onboarding() {
disabled={ !! error || selectedSite?.isAddingSite }
variant="primary"
>
{ selectedSite?.isAddingSite ? __( 'Adding site…' ) : __( 'Add site' ) }
{ 'Add site' }
</Button>
</div>
</SiteForm>
Expand Down