Skip to content

Studio: Fix spinner color when adding a site - #367

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/spinner-color
Jul 18, 2024
Merged

Studio: Fix spinner color when adding a site #367
katinthehatsite merged 1 commit into
trunkfrom
fix/spinner-color

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

After merging #362 , I noticed a small inconsistency in the design - the color of the spinner should be gray-70.

Before:
Screenshot 2024-07-18 at 9 32 41 AM

After:
Screenshot 2024-07-18 at 9 29 17 AM

Testing Instructions

  • Pull the changes from this branch
  • Start the app with nvm use && npm install && npm start
  • Click on the Add site button to open the modal
  • Click on Add site to add a site
  • Confirm that you see the loading indicator in the sidebar with the correct color

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Jul 18, 2024
@katinthehatsite
katinthehatsite requested a review from a team July 18, 2024 07:33
@matt-west

Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

@katinthehatsite
katinthehatsite merged commit 2de3ef9 into trunk Jul 18, 2024
@katinthehatsite
katinthehatsite deleted the fix/spinner-color branch July 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants