Clean up speculative Sentry logging - #3684
Merged
fredrikekelund merged 1 commit intoJun 3, 2026
Merged
Conversation
wojtekn
approved these changes
Jun 3, 2026
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for the claenup.
fredrikekelund
enabled auto-merge (squash)
June 3, 2026 12:21
Collaborator
📊 Performance Test ResultsComparing a917849 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
N/A
Proposed Changes
In #2793, we implemented a data migration from the old
appdata-v1.jsonconfig file to the new decoupled file strategy (living in~/.studio). During that data migration, we added Sentry logging to help us catch certain types of errors.Per pfHvTO-1ct-p2, we want to avoid leaving this kind of "speculative logging" in the code for longer periods of time, so this PR removes the
Sentry.captureExceptioncalls. These errors would only have occurred if theappdata-v1.jsonfile didn't conform to the expected schema. Luckily, we didn't catch any such errors.Testing Instructions
Code review is sufficient
Pre-merge Checklist