Skip to content

Clean up speculative Sentry logging - #3684

Merged
fredrikekelund merged 1 commit into
trunkfrom
stu-1478-clean-up-speculative-sentry-logging
Jun 3, 2026
Merged

Clean up speculative Sentry logging#3684
fredrikekelund merged 1 commit into
trunkfrom
stu-1478-clean-up-speculative-sentry-logging

Conversation

@fredrikekelund

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

N/A

Proposed Changes

In #2793, we implemented a data migration from the old appdata-v1.json config file to the new decoupled file strategy (living in ~/.studio). During that data migration, we added Sentry logging to help us catch certain types of errors.

Per pfHvTO-1ct-p2, we want to avoid leaving this kind of "speculative logging" in the code for longer periods of time, so this PR removes the Sentry.captureException calls. These errors would only have occurred if the appdata-v1.json file didn't conform to the expected schema. Luckily, we didn't catch any such errors.

Testing Instructions

Code review is sufficient

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fredrikekelund
fredrikekelund requested a review from bcotrim June 3, 2026 12:07
@fredrikekelund fredrikekelund self-assigned this Jun 3, 2026

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the claenup.

@fredrikekelund
fredrikekelund enabled auto-merge (squash) June 3, 2026 12:21
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing a917849 vs trunk

app-size

Metric trunk a917849 Diff Change
App Size (Mac) 1334.65 MB 1334.65 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk a917849 Diff Change
load 1680 ms 1659 ms 21 ms ⚪ 0.0%

site-startup

Metric trunk a917849 Diff Change
siteCreation 9003 ms 9056 ms +53 ms 🔴 0.6%
siteStartup 4420 ms 4401 ms 19 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@fredrikekelund
fredrikekelund merged commit 438967a into trunk Jun 3, 2026
12 checks passed
@fredrikekelund
fredrikekelund deleted the stu-1478-clean-up-speculative-sentry-logging branch June 3, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants