Studio: Disable 'Add site' button when site is being added - #371
Merged
Conversation
katinthehatsite
commented
Jul 19, 2024
| variant="outlined" | ||
| className={ className } | ||
| onClick={ openModal } | ||
| disabled={ isSiteAdding } |
Contributor
Author
There was a problem hiding this comment.
I tried using isBusy here but it was not good looking in terms of design and also still opened the modal so I prefer to use disabled
wojtekn
approved these changes
Jul 19, 2024
wojtekn
left a comment
wojtekn
left a comment
Contributor
There was a problem hiding this comment.
The code change looks clear. It works as expected on both macOS and Windows.
sejas
reviewed
Jul 19, 2024
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this improvement.
I tested it by clicking and using the shortcut cmd+n it works as expected:
OjXUlL.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Automattic/dotcom-forge/issues/8342
Proposed Changes
This PR does the two following things:
Testing Instructions
nvm use && npm install && npm startAdd sitein the sidebar and start the processAdd sitebutton is disabled while the new site is being created and you can't trigger the modal:Add sitein the sidebar and start the process againcmd + Non your keyboardAdd sitemodal does not appearcmd + Non your keyboardAdd sitemodal appearsPre-merge Checklist