Bring the interactive site selector to pull-reprint by epeicher · Pull Request #3729 · Automattic/studio

epeicher · 2026-06-08T17:09:39Z

Related issues

Fixes STU-1811

Selector compared with previous one

How AI was used in this PR

Claude Code adapted the existing pull site selector (pickSyncSite) into a trimmed pull-reprint variant per the issue's guidance to copy rather than abstract (since pull is being deprecated), added unit tests for both the picker and the source-resolution flow, and verified the change — cli:build, typecheck, and the new test suites all pass. I reviewed the diff against the reference implementation and confirmed there are no behavior changes on the non-interactive paths.

Proposed Changes

When you run pull-reprint without --url and have more than one connected WordPress.com site, the command previously printed the list and aborted, forcing you to re-run with an explicit --url. Now, in an interactive terminal, it opens a searchable site picker (type to filter by name or hostname, arrow keys to navigate, Enter to select) — the same friendly selection experience already offered by pull. Cancelling with Esc or Ctrl-C is treated as a clean no-op: nothing is downloaded and no local state is created.

Existing behavior is preserved everywhere else: a single connected site is still auto-selected, the zero-site and --url/--secret paths are unchanged, and non-interactive callers (CI, the Desktop app driving the CLI) keep the original print-list-and-abort behavior so scripted usage is unaffected.

Testing Instructions

Authenticate with a WordPress.com account that has two or more connected sites (studio auth login).

From an interactive terminal, run:

STUDIO_ENABLE_PULL_REPRINT=true node apps/cli/dist/cli/main.mjs pull-reprint --verbose

(run npm run cli:build first)

Confirm the interactive picker appears. Type to filter, select a site, and verify the pull proceeds against the chosen site.
Re-run and press Esc (or Ctrl-C) at the picker — confirm it exits cleanly with no site created under ~/Studio/ and no state under ~/.studio/pulls/.
Regression checks: with a single connected site it should auto-select without prompting; piping to a non-TTY (e.g. ... pull-reprint | cat) should fall back to printing the list and aborting.

Pre-merge Checklist

Have you checked for TypeScript, React or other console errors?

…sites

…interactive-site-selector-to-pull-reprint # Conflicts: # apps/cli/commands/tests/pull-reprint.test.ts

…ring-the-interactive-site-selector-to-pull-reprint

wpmobilebot · 2026-06-09T16:44:05Z

📊 Performance Test Results

Comparing d43d5bd vs trunk

app-size

Metric	trunk	`d43d5bd`	Diff	Change
App Size (Mac)	1328.22 MB	1328.22 MB	+0.00 MB	⚪ 0.0%

site-editor

Metric	trunk	`d43d5bd`	Diff	Change
load	1647 ms	1621 ms	26 ms	⚪ 0.0%

site-startup

Metric	trunk	`d43d5bd`	Diff	Change
siteCreation	8036 ms	8028 ms	8 ms	⚪ 0.0%
siteStartup	3917 ms	3913 ms	4 ms	⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

…interactive-site-selector-to-pull-reprint

…or-to-pull-reprint

fredrikekelund

The control works well, but we need to look into the site list fetching. Right now, non-Atomic sites are displayed in the list, but selecting them leads to an error like this for me:

✖ Invalid API response format: Zod validation failed: [
  {
    "expected": "string",
    "code": "invalid_type",
    "path": [
      "body",
      "data",
      "secret"
    ],
    "message": "Invalid input: expected string, received undefined"
  }
]. Raw response: {"code":404,"headers":[{"name":"Content-Type","value":"application/json"}],"body":{"error":"rest_no_route","message":"No route was found matching the URL and request method.","data":{"status":404}}}

fredrikekelund · 2026-06-11T10:20:04Z

+/**
+ * Interactive, searchable WordPress.com site picker.
+ *
+ * A trimmed clone of `pickSyncSite` (`apps/cli/lib/sync-site-picker.ts`)
+ * for the `pull-reprint` source-selection flow.  It keeps the
+ * `[staging]` badge but, because `WpComSiteInfo` has no `syncSupport`,
+ * drops the disabled-entry and sync-support logic — every site is
+ * selectable.
+ *
+ * Type-to-filter matches on the site name and normalized hostname.  Esc
+ * cancels the prompt (TTY only, via an `AbortController` wired to the
+ * raw escape byte) and resolves to `undefined`, as does Ctrl-C — so the
+ * caller can treat a cancellation as a clean no-op rather than an error.
+ */


In my testing, it doesn't appear that Reprint can sync non-Atomic sites. I would think this should be theoretically possible with how the Reprint exporter is deployed through wpcomsh, but I'm not familiar enough with wpcomsh to say for sure.

In any case, we need to adjust this implementation:

We should only display syncable sites in the list. The simple solution to this problem is to change the site fetching to use the same implementation as apps/cli/commands/pull.ts

If we do this, then there's not really a need for separate implementations between the pull and pull-reprint commands, as I understand it. Yes, the Jetpack-powered pull command is going away soon enough, so this isn't very important, but it'd be a nice touch.

We should talk to Adam about whether Reprint is intended to work for simple sites, too, and what adjustments we might need to make that work.

separate implementations

I guess I explicitly said not to worry about this in the Linear issue 😅 Let's ignore this unless the implementation end up 1:1

Well spotted! I didn't have any simple sites so when comparing with the pull command I was obtaining the same results, I will work on that.

Addressed as part of a5ea784

fredrikekelund · 2026-06-11T11:41:19Z

+			// In a real terminal, let the user pick interactively. Outside a
+			// TTY (CI, Desktop driving the command), keep the original
+			// print-list-and-abort behavior so scripted callers are
+			// unaffected.
+			if ( ! process.stdin.isTTY ) {
+				console.log( __( 'Connected WordPress.com sites:' ) );
+				console.log( formatWpComSitesList( sites ) );
+				console.log( '' );
+				throw new LoggerError(
+					__( 'Multiple WordPress.com sites are available. Re-run with `--url <site-url>`.' )
+				);
+			}


If no --url option was provided and this isn't a TTY, I think it's fine to just exit with an error. Realistically, the main case in which this command would be triggered in a non-TTY context is when it is spawned as a child command of Studio.

If we follow this suggestion, then let's also remove the formatWpComSitesList function.

I could also see us moving the if ( ! process.stdin.isTTY ) into the pickWpComSite implementation, but I'll leave that to you, @epeicher

Addressed as part of fc3d1fa, with regards to moving the condition, I prefer the TTY gate at the call site: "are we allowed to prompt, and what do we do if not?" and keep the picker focused on "given a list, return a choice or a cancel."

…site-selector-to-pull-reprint' into studio-10-bring-the-interactive-site-selector-to-pull-reprint

…or-to-pull-reprint

…and picker

…site-selector-to-pull-reprint' into studio-10-bring-the-interactive-site-selector-to-pull-reprint

epeicher · 2026-06-12T18:19:16Z

Hi @fredrikekelund, after our conversation, I have checked the conditions to pull sites and I've decided to unify them so pull and pull-reprint use the same logic. The jetpack and is_wpcom_atomic conditions are basically the same, I have not been able to simulate an atomic non-jetpack site so I don't think we need to worry about that.

The logic is greatly simplified, can you have a look at it and let me know any issues?

…or-to-pull-reprint

fredrikekelund

Looks good! 👍 There's more we can do to streamline and simplify site fetching and preflight logic, but we can do that in follow-up PRs

Add interactive site selector to pull-reprint for multiple connected …

851f3bb

…sites

github-actions Bot assigned epeicher Jun 8, 2026

epeicher added 2 commits June 9, 2026 18:09

Merge remote-tracking branch 'origin/trunk' into studio-10-bring-the-…

22c980f

…interactive-site-selector-to-pull-reprint # Conflicts: # apps/cli/commands/tests/pull-reprint.test.ts

Show [staging] badge in pull-reprint site picker

97db1ce

epeicher marked this pull request as ready for review June 9, 2026 16:20

Merge branch 'trunk' of github.com:Automattic/studio into studio-10-b…

a623c79

…ring-the-interactive-site-selector-to-pull-reprint

epeicher requested a review from fredrikekelund June 9, 2026 16:21

epeicher added 3 commits June 10, 2026 09:49

Fix missing isStaging in findMatchingWpComSite test fixture

ee37d4d

Merge remote-tracking branch 'origin/trunk' into studio-10-bring-the-…

66f7a26

…interactive-site-selector-to-pull-reprint

Merge branch 'trunk' into studio-10-bring-the-interactive-site-select…

e34606f

…or-to-pull-reprint

fredrikekelund reviewed Jun 11, 2026

View reviewed changes

epeicher added 6 commits June 11, 2026 17:36

Exclude Simple WordPress.com sites from pull-reprint

a5ea784

Merge remote-tracking branch 'origin/studio-10-bring-the-interactive-…

ff95442

…site-selector-to-pull-reprint' into studio-10-bring-the-interactive-site-selector-to-pull-reprint

Simplify non-TTY pull-reprint to error without listing sites

fc3d1fa

Merge branch 'trunk' into studio-10-bring-the-interactive-site-select…

af52a09

…or-to-pull-reprint

Unify pull-reprint site selection with pull's syncable-sites fetcher …

1a5e8ed

…and picker

Merge remote-tracking branch 'origin/studio-10-bring-the-interactive-…

371e27d

…site-selector-to-pull-reprint' into studio-10-bring-the-interactive-site-selector-to-pull-reprint

Merge branch 'trunk' into studio-10-bring-the-interactive-site-select…

d43d5bd

…or-to-pull-reprint

fredrikekelund approved these changes Jun 15, 2026

View reviewed changes

epeicher merged commit 6116d4c into trunk Jun 15, 2026
12 checks passed

epeicher deleted the studio-10-bring-the-interactive-site-selector-to-pull-reprint branch June 15, 2026 10:10

fredrikekelund mentioned this pull request Jul 7, 2026

pull-reprint: pick a WP.com site interactively when no --url is given #3239

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bring the interactive site selector to pull-reprint - #3729

Bring the interactive site selector to pull-reprint#3729
epeicher merged 14 commits into
trunkfrom
studio-10-bring-the-interactive-site-selector-to-pull-reprint

epeicher commented Jun 8, 2026 •

edited

Loading

wpmobilebot commented Jun 9, 2026 •

edited

Loading

fredrikekelund left a comment

fredrikekelund Jun 11, 2026

fredrikekelund Jun 11, 2026 •

edited

Loading

epeicher Jun 11, 2026

epeicher Jun 11, 2026

fredrikekelund Jun 11, 2026

epeicher Jun 11, 2026

epeicher commented Jun 12, 2026

fredrikekelund left a comment

Uh oh!

Labels

3 participants

Uh oh!

Conversation

epeicher commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Selector compared with previous one

How AI was used in this PR

Proposed Changes

Testing Instructions

Pre-merge Checklist

wpmobilebot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Performance Test Results

app-size

site-editor

site-startup

fredrikekelund left a comment

Choose a reason for hiding this comment

fredrikekelund Jun 11, 2026

Choose a reason for hiding this comment

fredrikekelund Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

epeicher Jun 11, 2026

Choose a reason for hiding this comment

epeicher Jun 11, 2026

Choose a reason for hiding this comment

fredrikekelund Jun 11, 2026

Choose a reason for hiding this comment

epeicher Jun 11, 2026

Choose a reason for hiding this comment

epeicher commented Jun 12, 2026

fredrikekelund left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

3 participants

epeicher commented Jun 8, 2026 •

edited

Loading

wpmobilebot commented Jun 9, 2026 •

edited

Loading

fredrikekelund Jun 11, 2026 •

edited

Loading