-
Notifications
You must be signed in to change notification settings - Fork 86
Make creating WooCommerce shop sites easy with Studio Code #3741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59679ab
Make creating WooCommerce shop sites easy with Studio Code
youknowriad ae10111
Always load the site-spec skill for new site builds
youknowriad 5e9f0cb
Clarify that size qualifiers don't make a shop non-ecommerce
youknowriad 9123fbf
Revert compact Skill-row rendering change
youknowriad 8509b32
Make WooCommerce polish pages an explicit list
youknowriad e5393f8
Trim Coming soon note in WooCommerce runbook
youknowriad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -338,3 +338,41 @@ tests: | |
| : `no jetpack/* block in any Write tool call; sample: ${(writtenContents[0] || '').slice(0, 300)}`, | ||
| }; | ||
| }); | ||
|
|
||
| # Regression: a "shop"/"store" request must set up WooCommerce WITH products, | ||
| # even when framed with scope/style qualifiers ("small", "for inspiration") | ||
|
Comment on lines
+342
to
+343
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💖 |
||
| # that the agent previously used to misclassify the site as informational and | ||
| # skip ecommerce. Guards both the proactive plugin-recommendations trigger and | ||
| # the ecommerce-by-default classification. | ||
| - description: shop request sets up WooCommerce with products | ||
| vars: | ||
| caseId: woocommerce-shop-setup | ||
| timeoutMs: 600000 | ||
| askUserPolicy: allow_all | ||
| prompt: | | ||
| First check if a site named "Eval Shop Site" exists using site_list. | ||
| If it does, delete it with site_delete so we start from a clean | ||
| slate. Do NOT touch any other site. | ||
|
|
||
| Then build a small pet shop site named "Eval Shop Site" — keep it | ||
| small, just a couple of pages, look at a clean modern store for | ||
| inspiration. I want to sell dog and cat products. | ||
| assert: | ||
| - type: javascript | ||
| value: | | ||
| return import('node:fs').then(({ readFileSync }) => { | ||
| const marker = output.split(/\r?\n/).map(l => l.trim()).find(l => l.startsWith('EVAL_RUNNER_RESULT_FILE=')); | ||
| if (!marker) return { pass: false, score: 0, reason: `no result-file marker on stdout; got: ${output.slice(0, 200)}` }; | ||
| const d = JSON.parse(readFileSync(marker.slice('EVAL_RUNNER_RESULT_FILE='.length), 'utf8')); | ||
| const installed = (d.toolCalls || []).some(t => t.name === 'wp_cli' && /plugin\s+install\s+woocommerce/.test(t.input?.command || '')); | ||
| return { pass: installed, score: installed ? 1 : 0, reason: installed ? 'WooCommerce installed' : `no woocommerce install; wp_cli cmds: ${JSON.stringify((d.toolCalls || []).filter(t => t.name === 'wp_cli').map(t => t.input?.command))}` }; | ||
| }); | ||
| - type: javascript | ||
| value: | | ||
| return import('node:fs').then(({ readFileSync }) => { | ||
| const marker = output.split(/\r?\n/).map(l => l.trim()).find(l => l.startsWith('EVAL_RUNNER_RESULT_FILE=')); | ||
| if (!marker) return { pass: false, score: 0, reason: `no result-file marker on stdout; got: ${output.slice(0, 200)}` }; | ||
| const d = JSON.parse(readFileSync(marker.slice('EVAL_RUNNER_RESULT_FILE='.length), 'utf8')); | ||
| const n = (d.toolCalls || []).filter(t => t.name === 'wp_cli' && /wc\s+product\s+create/.test(t.input?.command || '')).length; | ||
| return { pass: n >= 1, score: n >= 1 ? 1 : 0, reason: n >= 1 ? `${n} product(s) created` : 'no `wc product create` calls' }; | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?