Skip to content

Dark theme: fix tab hover color - #3745

Merged
nightnei merged 3 commits into
trunkfrom
fixTabsColor
Jun 9, 2026
Merged

Dark theme: fix tab hover color#3745
nightnei merged 3 commits into
trunkfrom
fixTabsColor

Conversation

@nightnei

@nightnei nightnei commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

How AI was used in this PR

AI implemented changes, but I manually adjusted by removing ! important and redundant generated styles.

Proposed Changes

Let's align tabs hover styles for Dark theme with Light theme.

Before:

Screenshot 2026-06-09 at 16 45 55
After:

Screenshot 2026-06-09 at 16 46 15

Testing Instructions

  1. npm start
  2. Assert that for Light theme tabs look good (default, hover, active). Also yo ucan open Studio Settings and site Settings to assert that everythign good tehre too.
  3. Turn on Dark mode
  4. Assert that for Dark theme tabs look good (default, hover, active) and styles aligned with Light mode (no hover effect, etc).
@nightnei
nightnei requested a review from a team June 9, 2026 15:49
@nightnei nightnei self-assigned this Jun 9, 2026
@wpmobilebot

wpmobilebot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 8344e59 vs trunk

app-size

Metric trunk 8344e59 Diff Change
App Size (Mac) 1384.39 MB 1384.39 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 8344e59 Diff Change
load 1695 ms 1629 ms 66 ms 🟢 -3.9%

site-startup

Metric trunk 8344e59 Diff Change
siteCreation 9035 ms 9032 ms 3 ms ⚪ 0.0%
siteStartup 4402 ms 4399 ms 3 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I did not find any regressions in light mode

Before After
Image Image
@nightnei
nightnei enabled auto-merge (squash) June 9, 2026 16:33
@nightnei
nightnei merged commit 95ef0c4 into trunk Jun 9, 2026
11 checks passed
@nightnei
nightnei deleted the fixTabsColor branch June 9, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants