Skip to content

Move onboarding ToS/Privacy notice above the login CTA - #3764

Merged
sejas merged 3 commits into
trunkfrom
stu-1734-move-onboarding-tos-above-cta
Jun 10, 2026
Merged

Move onboarding ToS/Privacy notice above the login CTA#3764
sejas merged 3 commits into
trunkfrom
stu-1734-move-onboarding-tos-above-cta

Conversation

@sejas

@sejas sejas commented Jun 10, 2026

Copy link
Copy Markdown
Member

Related issues

How AI was used in this PR

AI was used to locate the onboarding component, move the legal notice block, and run lint/typecheck/tests.

Proposed Changes

  • On the onboarding screen, the "By continuing, you agree to our Terms of Service and have read our Privacy Policy." notice was pinned to the bottom of the window, far from the actions it refers to. It now appears directly above the "Log in to WordPress.com" / "Skip" buttons, so users see the terms before continuing — matching the intent of the one-time ToS disclaimer work in Show one-time ToS/Privacy disclaimer in Studio CLI and Studio Code #3763.

Testing Instructions

  • Launch Studio with a fresh profile (or reset onboarding) so the onboarding screen appears.
  • Verify the ToS/Privacy notice renders above the "Log in to WordPress.com" and "Skip" buttons, and is no longer pinned at the bottom of the screen.
  • Verify the Terms of Service and Privacy Policy links still open in the browser.
  • Check the screen in both light and dark mode.
Before  After
Screenshot 2026-06-10 at 15 55 23 Screenshot 2026-06-10 at 15 53 15

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@sejas sejas self-assigned this Jun 10, 2026
@sejas
sejas marked this pull request as ready for review June 10, 2026 14:55
@sejas
sejas requested a review from nightnei June 10, 2026 14:55

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Image

Image

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas, I can see the ToS in the expected position for light and dark modes. LGTM!

Light Dark
Image Image
@katinthehatsite

Copy link
Copy Markdown
Contributor

I pushed an empty commit to trigger CI because I did not see any other option to do it. For some reason, the Code QL action was failing.

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing e65392b vs trunk

app-size

Metric trunk e65392b Diff Change
App Size (Mac) 1358.08 MB 1358.08 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk e65392b Diff Change
load 1681 ms 1691 ms +10 ms ⚪ 0.0%

site-startup

Metric trunk e65392b Diff Change
siteCreation 9058 ms 9038 ms 20 ms ⚪ 0.0%
siteStartup 4398 ms 4448 ms +50 ms 🔴 1.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@sejas
sejas merged commit c081bb4 into trunk Jun 10, 2026
11 checks passed
@sejas
sejas deleted the stu-1734-move-onboarding-tos-above-cta branch June 10, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants