Skip to content

Use Tooltip props object for disabled update button - #388

Merged
katinthehatsite merged 1 commit into
add/ui-for-when-user-is-blockedfrom
update/ui-for-blocked-update-demo-sites
Jul 25, 2024
Merged

Use Tooltip props object for disabled update button#388
katinthehatsite merged 1 commit into
add/ui-for-when-user-is-blockedfrom
update/ui-for-blocked-update-demo-sites

Conversation

@sejas

@sejas sejas commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed Changes

  • Simplify logic on update check
  • It also solves a weird edge case where we displayed a wrong message after enabling the network

See the screencast:

s1nhTb.mp4

Testing Instructions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Jul 25, 2024
@sejas
sejas requested review from a team and katinthehatsite July 25, 2024 14:02
@sejas sejas mentioned this pull request Jul 25, 2024
Merged
1 task
@katinthehatsite

katinthehatsite commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Looks good to me let's merge it into the branch 👍
@katinthehatsite
katinthehatsite merged commit 1faca89 into add/ui-for-when-user-is-blocked Jul 25, 2024
@katinthehatsite
katinthehatsite deleted the update/ui-for-blocked-update-demo-sites branch July 25, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sejas @katinthehatsite