Skip to content

UX: clarify naming between site-level and app-level Settings - #3886

Merged
katinthehatsite merged 7 commits into
trunkfrom
add/user-settings-to-settings
Jun 19, 2026
Merged

UX: clarify naming between site-level and app-level Settings#3886
katinthehatsite merged 7 commits into
trunkfrom
add/user-settings-to-settings

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1694

How AI was used in this PR

It was used to update the tests and do the implementation.

Proposed Changes

  • Pull the changes from this branch
  • Start Studio with npm start
  • Confirm that the Settings tab is now changed to Site Settings
  • Confirm that all the tests are passing

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Jun 18, 2026
@katinthehatsite
katinthehatsite requested a review from a team June 18, 2026 13:09

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and work as described

Image
Comment thread apps/studio/e2e/page-objects/site-content.ts
@katinthehatsite
katinthehatsite requested a review from bcotrim June 19, 2026 08:32

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @katinthehatsite! I have tested it, and I can see the new Site Settings tab as expected. Also navigating to other tabs work as expected. I would say that once the E2E tests pass, this could be merged. LGTM!

Image
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 550d664 vs trunk

app-size

Metric trunk 550d664 Diff Change
App Size (Mac) 2357.83 MB 2357.83 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 550d664 Diff Change
load 1058 ms 1092 ms +34 ms ⚪ 0.0%

site-startup

Metric trunk 550d664 Diff Change
siteCreation 6482 ms 6470 ms 12 ms ⚪ 0.0%
siteStartup 6991 ms 6998 ms +7 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@katinthehatsite
katinthehatsite merged commit 235f562 into trunk Jun 19, 2026
11 checks passed
@katinthehatsite
katinthehatsite deleted the add/user-settings-to-settings branch June 19, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants