STU-1873: Improve tool call descriptions - #3903
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 01e7e84 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
…l-descriptions # Conflicts: # apps/ui/src/ui-desks/chats/conversation/index.tsx
bcotrim
approved these changes
Jun 22, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Works as described
| Before | After |
|---|---|
 |
 |
| ); | ||
| } | ||
|
|
||
| function getWpCliOptionValue( args: string[], option: string ): string | undefined { |
Contributor
There was a problem hiding this comment.
We already have a very similar function in apps/cli/ai/tools/wp-cli.ts, I suggest re-using it.
Contributor
Author
There was a problem hiding this comment.
do you think it makes sense to move this into tools/common?
Contributor
There was a problem hiding this comment.
Yes, I think that's a good approach
shaunandrews
added a commit
that referenced
this pull request
Jun 24, 2026
<img width="496" height="547" alt="image" src="https://github.com/user-attachments/assets/eeb56c55-d6cb-43e8-a528-c3d17cca02b9" /> <img width="498" height="518" alt="image" src="https://github.com/user-attachments/assets/3c30cdfc-e925-4b42-8f07-f5acc8f0ffc7" /> ## Related issues - Related to https://linear.app/a8c/issue/STU-1873/studio-agentic-ui-improve-tool-call-presentation - Follow-up to #3903 ## How AI was used in this PR I used AI assistance to port the tool-row presentation from the older exploration branch onto current trunk, keep the scope limited to the classic Agentic UI transcript, and add regression tests. I reviewed the final diff, updated the branch after #3903 landed, ran automated checks, and verified the UI in light and dark modes with a temporary Vite harness. ## Proposed Changes - Makes classic Agentic UI tool calls easier to scan by showing an icon, a human-readable label, and a compact detail. - Lets users expand a tool row to inspect the command/input and output without long output taking over the transcript. - Keeps Ask User questions from rendering a duplicate raw tool row, so the custom question UI remains the only visible prompt. ## Testing Instructions - Run `npm test -- tools/common/ai/tests/tools.test.ts apps/ui/src/ui-classic/components/session-view/conversation/index.test.ts`. - Run `npm run typecheck`. - In classic Agentic UI, trigger tool calls such as WP-CLI and Bash, then click the tool rows to confirm input/output appears inside a bounded scrollable details panel. - Check the tool rows and expanded details in both light and dark color schemes. ## Pre-merge Checklist - [x] Have you checked for TypeScript, React or other console errors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
I used AI assistance to inspect the existing tool-call rendering surfaces, port the shared description changes from the older exploration branch, and add focused tests around the shared helper behavior. I reviewed the resulting diff and ran the checks listed below.
Proposed Changes
Testing Instructions
npx eslint --fix apps/cli/ai/ui.ts apps/studio/src/components/studio-code-session/conversation/index.tsx apps/ui/src/ui-classic/components/session-view/conversation/index.tsx tools/common/ai/tools.ts tools/common/ai/tests/tools.test.ts.npm test -- tools/common/ai/tests/tools.test.ts apps/cli/ai/tests/ui.test.ts apps/studio/src/components/studio-code-session/conversation/index.test.tsx.npm run typecheck.Pre-merge Checklist