STU-1874: Improve Ask User option rendering - #3905
Merged
Merged
Conversation
shaunandrews
marked this pull request as ready for review
June 24, 2026 14:18
Collaborator
📊 Performance Test ResultsComparing 151228c vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
bcotrim
reviewed
Jun 25, 2026
Contributor
Author
|
Thanks for the review, folks. I've fixed everything here. I also added some more work around batch questions. Appreciate another review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issues
How AI was used in this PR
Codex implemented the scoped Ask User rendering changes, added tests for historical answer handling, and ran the verification commands below. I reviewed the diff and adjusted the live answer cache update to avoid touching older duplicate questions.
Proposed Changes
ask_userprompts.aria-pressedfor selected choices and description text connected viaaria-describedby.Testing Instructions
npx eslint --fix apps/ui/src/data/queries/use-agent-run.tsx apps/ui/src/ui-classic/components/session-view/conversation/index.tsx apps/ui/src/ui-classic/components/session-view/conversation/index.test.ts tools/common/ai/sessions/entry-types.ts apps/ui/src/ui-classic/components/session-view/conversation/style.module.cssnpm run typechecknpm test -- tools/common/ai/tests/tools.test.ts apps/cli/ai/tests/ui.test.ts apps/ui/src/ui-desks/chats/conversation/index.test.ts apps/ui/src/ui-classic/components/session-view/conversation/index.test.tsPre-merge Checklist