Add Studio Code slide to What's New modal - #3924
Merged
sejas merged 12 commits intoJun 24, 2026
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 0d99e64 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
katinthehatsite
approved these changes
Jun 23, 2026
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes look good to me but I left one suggestion for wording that I think sounds slighly better and more natural
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
…code-to-studio-whats-new-modal # Conflicts: # apps/studio/src/lib/get-localized-link.ts # apps/studio/src/modules/whats-new/components/whats-new-modal.tsx
Member
Author
|
@shaunandrews , feel free to make any edits or leave your feedback. I used the image you suggested. |
Contributor
Improved the SVG sizing, blurring, and added the dotgrid background. I also updated the copy to focus more on the value add; the previous suggestion assumed the reader understand what Studio Code was, and that it was previously available in the CLI. |
Member
Author
|
Thanks Shaun! ✨ |
1 task
bcotrim
added a commit
that referenced
this pull request
Jun 24, 2026
## Related issues - Follow-up to #3915 — fixes the truncation reported in [review feedback](#3915 (comment)) - Related to [RSM-4414](https://linear.app/a8c/issue/RSM-4414/update-the-whats-new-modal-with-details-about-the-native-php-runtime) ## How AI was used in this PR Used Claude Code (Opus 4.8) to diagnose the truncation, trace the history of the modal's line-clamp behavior, and implement the fix. I confirmed the modal renders every slide's copy in full (no truncation, no scrollbar) in the running app, and ran ESLint + a typecheck on the changed file. ## Proposed Changes The **"Faster local sites with native PHP"** slide in the What's New modal was cutting its description off mid-sentence (*"…switch between Native…"*). The root cause was a fragile rule, not the copy itself: the modal clamped the **first** slide's description to 5 lines but **every other** slide to 3. The native PHP copy was written while it was the lead slide; once a Studio Code slide became the new lead (#3924), native PHP dropped into a 3-line slot and its (unchanged) text no longer fit. Rather than trimming the copy, this gives **every slide the same 5-line clamp** the intro slide already used — which the fixed-height modal accommodates without scrollbars. That removes the intro-vs-regular distinction that caused the regression, so future copy tweaks or slide reordering won't silently truncate. It also drops a leftover wrapper element that had no styling. The slide copy is unchanged from `trunk`. Thanks to @fredrikekelund for [suggesting](#3946 (review)) the all-slides approach over a copy-only fix. ## Testing Instructions 1. Run Studio (`npm start`). 2. Open the What's New modal (app menu → **What's New**). 3. Page through every slide and confirm each description shows in full with no truncation/ellipsis — in particular, the **"Faster local sites with native PHP"** slide should end with *"…in your site settings."* 4. Confirm no scrollbar appears on any slide and the footer buttons stay in place. 5. Verify in **both light and dark** appearance. ## Pre-merge Checklist - [x] Have you checked for TypeScript, React or other console errors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI assistance was used to scaffold the new slide by following the existing
WhatsNewPagepattern (imports, slide entry, localized link). All copy, the docs URL, and placement were reviewed and adjusted by hand.Proposed Changes
Studio Code — the agentic WordPress expert previously available only via the CLI/terminal — is now part of the Studio desktop app, replacing v1 of the AI assistant. This adds a "What's New" slide so users discover it on launch.
Testing Instructions
npm start.lastSeenVersionto hit the first-launch path).The image is temporal. I'll replace it once we have a final one in STU-1896
Pre-merge Checklist