Learn more links under "PHP runtime" controls - #3926
Conversation
📊 Performance Test ResultsComparing 7741298 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
| : __( | ||
| 'Runs the site in an isolated WordPress Playground sandbox.' | ||
| ) }{ ' ' } | ||
| <LearnMoreLink docsLinksKey="docsPhpRuntimes" /> |
There was a problem hiding this comment.
Let's use createInterpolateElement to avoid interpolating translatable texts.
There was a problem hiding this comment.
We aren't interpolating anything into the __() call here. I see we're using createInterpolateElement elsewhere in this file, but the practical implications of both approaches seem identical to me (apart from <lean_more_link /> being included in the translatable string with createInterpolateElement).
There was a problem hiding this comment.
My bad, I meant concatenating. See PCYsg-3hI-p2
but the practical implications of both approaches seem identical to me
Not really - if we interpolate instead concatenate, translator could reorder elements if particular language requires that, could add text after "Learn more", wrap it with some characters etc.
There was a problem hiding this comment.
That's actually a good point 👍 I pushed a fix
Related issues
How AI was used in this PR
I asked Claude to do the implementation mostly because I didn't know by heart where the site controls live.
Proposed Changes
Add "Learn more" links to the create site and edit site modals:
Testing Instructions
npm startPre-merge Checklist