Skip to content

Learn more links under "PHP runtime" controls - #3926

Merged
fredrikekelund merged 3 commits into
trunkfrom
rsm-4475-native-php-learn-more
Jun 23, 2026
Merged

Learn more links under "PHP runtime" controls#3926
fredrikekelund merged 3 commits into
trunkfrom
rsm-4475-native-php-learn-more

Conversation

@fredrikekelund

Copy link
Copy Markdown
Contributor

Related issues

  • Fixes RSM-4475

How AI was used in this PR

I asked Claude to do the implementation mostly because I didn't know by heart where the site controls live.

Proposed Changes

Add "Learn more" links to the create site and edit site modals:

Add site modal Edit site modal
Screenshot 2026-06-23 at 13 58 56 Screenshot 2026-06-23 at 13 59 07

Testing Instructions

  1. npm start
  2. Add a new site
  3. Open the advanced settings control
  4. Ensure that the "Learn more" link under "PHP runtime" leads to the correct documentation page (privately published for now)
  5. Open the "Site settings" tab for an existing site
  6. Click the "Edit site" button
  7. Ensure that the "Learn more" link under "PHP runtime" leads to the correct documentation page (privately published for now)

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fredrikekelund
fredrikekelund requested review from a team and wojtekn June 23, 2026 12:03
@fredrikekelund fredrikekelund self-assigned this Jun 23, 2026
@wpmobilebot

wpmobilebot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 7741298 vs trunk

app-size

Metric trunk 7741298 Diff Change
App Size (Mac) 2341.17 MB 2341.17 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 7741298 Diff Change
load 794 ms 1035 ms +241 ms 🔴 30.4%

site-startup

Metric trunk 7741298 Diff Change
siteCreation 6499 ms 6524 ms +25 ms ⚪ 0.0%
siteStartup 6983 ms 6490 ms 493 ms 🟢 -7.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

: __(
'Runs the site in an isolated WordPress Playground sandbox.'
) }{ ' ' }
<LearnMoreLink docsLinksKey="docsPhpRuntimes" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use createInterpolateElement to avoid interpolating translatable texts.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't interpolating anything into the __() call here. I see we're using createInterpolateElement elsewhere in this file, but the practical implications of both approaches seem identical to me (apart from <lean_more_link /> being included in the translatable string with createInterpolateElement).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I meant concatenating. See PCYsg-3hI-p2

but the practical implications of both approaches seem identical to me

Not really - if we interpolate instead concatenate, translator could reorder elements if particular language requires that, could add text after "Learn more", wrap it with some characters etc.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually a good point 👍 I pushed a fix

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@fredrikekelund
fredrikekelund requested a review from wojtekn June 23, 2026 14:10
@fredrikekelund
fredrikekelund enabled auto-merge (squash) June 23, 2026 14:15
@fredrikekelund
fredrikekelund merged commit 7915652 into trunk Jun 23, 2026
11 checks passed
@fredrikekelund
fredrikekelund deleted the rsm-4475-native-php-learn-more branch June 23, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants