Attempt to fix bloated installer size - #3943
Merged
Merged
Conversation
Primarily trying to reconcile the big jump in installer size that we saw recently
Collaborator
📊 Performance Test ResultsComparing 0b5f974 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
|
OK… So, clearly, the problem is not solved by upgrading the Playground dependencies 🤔 |
fredrikekelund
commented
Jun 24, 2026
| "typecheck": "tsc -p tsconfig.json --noEmit" | ||
| }, | ||
| "dependencies": { | ||
| "@formatjs/intl-locale": "^3.4.5", |
Contributor
Author
There was a problem hiding this comment.
This is just restoring my changes from #3776
Contributor
|
I saw that both unit tests and e2e tests were failing so I retriggered them - the unit tests are good now. It seems that e2e tests are still failing 🤔 |
…nto f26d/package-updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily trying to reconcile the big jump in installer size that we saw recently
Related issues
N/A
How AI was used in this PR
N/A
Proposed Changes
#3829 bumped the installer size significantly. We discussed this just after that PR was merged, and I made an effort in #3784 to fix the problem. Turns out that didn't work, because the installer size is still huge.
This PR fixes the problem by restoring the
--omit=devoption in theinstall:bundlescript that's used to packageapps/studiodependencies when building the app.Testing Instructions
See installer size results from performance metrics CI job
Pre-merge Checklist