Skip to content

Studio: Improve the loading progress bar on Windows - #398

Merged
katinthehatsite merged 1 commit into
trunkfrom
fix/improve-progress-bar-on-windows
Jul 30, 2024
Merged

Studio: Improve the loading progress bar on Windows#398
katinthehatsite merged 1 commit into
trunkfrom
fix/improve-progress-bar-on-windows

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Closes: https://github.com/Automattic/dotcom-forge/issues/8340

Proposed Changes

This PR improves the loading of the progress bar on Windows by setting a starting point earlier.

Testing Instructions

  • This change would need to be tested on Windows
  • Pull the changes from this branch
  • Start the app with STUDIO_IMPORT_EXPORT=true npm start
  • Click on Add site in the left sidebar
  • Observe the loading progress starting earlier

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite
katinthehatsite requested a review from wojtekn July 29, 2024 14:29
@katinthehatsite katinthehatsite self-assigned this Jul 29, 2024
@wojtekn

wojtekn commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Start the app with STUDIO_IMPORT_EXPORT=true npm start

No need to provide that flag to test it. The code change is clear, and works better. Thanks!

@katinthehatsite
katinthehatsite merged commit 488601f into trunk Jul 30, 2024
@katinthehatsite
katinthehatsite deleted the fix/improve-progress-bar-on-windows branch July 30, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants