Skip to content

Fix Studio Code annotate closing message that always referenced the CLI - #4020

Merged
bcotrim merged 1 commit into
trunkfrom
stu-1920
Jul 1, 2026
Merged

Fix Studio Code annotate closing message that always referenced the CLI#4020
bcotrim merged 1 commit into
trunkfrom
stu-1920

Conversation

@bcotrim

@bcotrim bcotrim commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Used Claude to trace the annotate flow, confirm the same page script serves both the standalone CLI and desktop-app Studio Code sessions, and pick the source-agnostic wording fix. All changes were reviewed by me.

Proposed Changes

When a user finishes annotating in Studio Code's inspector, the closing countdown toast and the Done button tooltip told them to "return to the CLI". Most users reach this flow from the desktop app, so the message pointed them at the wrong place. The wording is now source-agnostic — the toast reads "Sent N annotation(s) — closing in Xs" and the tooltip reads "Send annotations and return" — so it's correct whether the session was launched from the app or the CLI.

Testing Instructions

  • In the Studio Code tab (desktop app), trigger the annotate flow and click Annotate.
  • Pick an element, add a comment, and hover Done — the tooltip should read "Send annotations and return".
  • Click Done — the countdown toast should read "Sent N annotation(s) — closing in Xs" with no "return to the CLI".

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim bcotrim self-assigned this Jul 1, 2026
@bcotrim
bcotrim requested a review from a team July 1, 2026 07:21
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing dfde712 vs trunk

app-size

Metric trunk dfde712 Diff Change
App Size (Mac) 1316.77 MB 1316.77 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk dfde712 Diff Change
load 1114 ms 744 ms 370 ms 🟢 -33.2%

site-startup

Metric trunk dfde712 Diff Change
siteCreation 6482 ms 6505 ms +23 ms ⚪ 0.0%
siteStartup 1863 ms 1861 ms 2 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these details @bcotrim! I have tested it, and I can see the new messages. LGTM!

Tooltip Close message
Image Image
@bcotrim
bcotrim merged commit d34bdc9 into trunk Jul 1, 2026
12 checks passed
@bcotrim
bcotrim deleted the stu-1920 branch July 1, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants