Skip to content

Fix plugin reinstall failure after deletion in Sandbox runtime #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wojtekn merged 7 commits into from
Jul 10, 2026
Merged

Fix plugin reinstall failure after deletion in Sandbox runtime #4044

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
844e9de
Fix plugin reinstall failure after deletion in Sandbox runtime
matticbot Jul 2, 2026
977ef84
Fix lint: remove unnecessary escapes on PHP variables in mu-plugin te…
wojtekn Jul 8, 2026
d7e52d9
Merge branch 'trunk' into fix-stu-1931-lint
wojtekn Jul 8, 2026
765428b
Trim clear-stat-cache docblock and exclude mu-plugin from native PHP …
wojtekn Jul 8, 2026
fafe2bc
Reference STU-1931 by code instead of full Linear URL
wojtekn Jul 8, 2026
784ca8a
Merge branch 'trunk' into ai/agent/stu-1931-1782979528
wojtekn Jul 8, 2026
270b16e
Shorten clear-stat-cache mu-plugin comment
wojtekn Jul 10, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/common/lib/mu-plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const NATIVE_PHP_EXCLUDED_MU_PLUGINS = new Set( [
'0-allowed-redirect-hosts.php',
'0-suppress-dns-get-record-warnings.php',
'0-http-request-timeout.php',
'0-clear-stat-cache-before-upgrade.php',
] );

export function escapePhpSingleQuotedString( value: string ): string {
Expand Down Expand Up @@ -408,6 +409,21 @@ function getStandardMuPlugins( options: MuPluginOptions ): MuPlugin[] {
`,
} );

// Playground's PHP persists stat caches across requests, so a deleted plugin
// can still look present and break a reinstall. Clear the cache before each
// upgrade. Excluded from native PHP, where every request starts clean.
//
// @see STU-1931
muPlugins.push( {
filename: '0-clear-stat-cache-before-upgrade.php',
content: `<?php
add_filter( 'upgrader_pre_install', function( $result ) {
clearstatcache( true );
return $result;
} );
`,
} );

// Studio-specific: Fix plugin spinner display
muPlugins.push( {
filename: '0-tmp-fix-hide-plugins-spinner.php',
Expand Down Expand Up @@ -761,6 +777,7 @@ export const LEGACY_MU_PLUGIN_FILENAMES = [
'0-allowed-redirect-hosts.php',
'0-auto-login.php',
'0-check-theme-availability.php',
'0-clear-stat-cache-before-upgrade.php',
'0-deactivate-jetpack-modules.php',
'0-disable-auto-updates.php',
'0-enable-auto-updates.php',
Expand Down
Loading