2nd take: Add weekly GitHub action cron job to check for new PHP versions - #4052
Merged
Conversation
## Related issues <!-- Link a related issue to this PR. If the PR does not immediately resolve the issue, for example, it requires a separate deployment to production, avoid using the "Fixes" keyword and use "Related to" instead. --> - Fixes RSM-4591 ## How AI was used in this PR <!-- Help reviewers understand what to look for and verify that you've reviewed the code yourself. --> Codex executed the implementation with iterative driving instructions from me. ## Proposed Changes <!-- Explain the intent of this PR: - What problem does it solve, or what need does it address? - How does it affect the user (new capability, fix, performance, accessibility, etc.)? - Note any user-visible behavior changes or trade-offs. Focus on the "why" and the user impact. Avoid listing modified files or describing implementation mechanics — the diff already shows that. --> The `Build PHP CLI Binaries` GitHub Actions workflow gives us a really smooth way of building new PHP binaries for all platforms. Input a PHP version and set `apps_cdn_visibility` to `external`, and you get a PR back that modifies the `php-binary-cdn-metadata.mjs` file. The missing piece is automation that looks for new PHP versions and automatically triggers those builds. This PR adds it as a weekly GitHub Actions cron job. For added safety, I've changed the `error_on_duplicate` parameter in the `Build PHP CLI Binaries` job to true. Overwriting existing appscdn packages would lead to errors in some local Studio CLI installations. We should only do that if we really know what we're doing. ## Testing Instructions <!-- Add as many details as possible to help others reproduce the issue and test the fix. "Before / After" screenshots can also be very helpful when the change is visual. --> 1. Generate a GitHub access token: https://github.com/settings/personal-access-tokens 2. Run `GH_TOKEN=xxxxxx node scripts/check-php-cli-versions.mjs` (this will only generate output and not trigger a CI workflow run) 3. Ensure that the script runs successfully (right now, you'll see that there are new PHP versions available) ## Pre-merge Checklist <!-- Complete applicable items on this checklist **before** merging into trunk. Inapplicable items can be left unchecked. Both the PR author and reviewer are responsible for ensuring the checklist is completed. --> - [ ] Have you checked for TypeScript, React or other console errors?
Contributor
Author
Contributor
|
@bcotrim, please help to bring this one to the finish line. |
…n-cron-check # Conflicts: # packages/common/lib/php-binary-cdn-metadata.mjs
Collaborator
📊 Performance Test ResultsComparing bde9b92 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This reverts commit 9f4aff6.
bcotrim
enabled auto-merge (squash)
July 14, 2026 10:14
bcotrim
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Codex executed the implementation with iterative driving instructions from me.
Proposed Changes
See description in #4026. I mistakenly merged that PR to the base branch
codex/remove-tsx-from-scriptsbefore #4021 has been merged totrunk(which is the workflow I want).This PR applies the changes from #4026 again, and it'll be merged after the base PR.
Testing Instructions
See #4026
Pre-merge Checklist