Use a neutral CLI log prefix instead of hard-coded 'site ID' - #4108
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing b9a8990 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issues
How AI was used in this PR
Claude wrote the code, guided by the author. The author tested it locally and manually reviewed it before pushing.
Proposed Changes
The stdout echo prefix hard-coded the words "site ID", but
logPrefixis also used for non-site contexts. For example, the CLI events subscriber passes "events", which produced the misleading line[CLI - site ID events]. The prefix is now the neutral[CLI - <prefix>], which matches the formatCliServerProcessalready uses for its own log lines.Testing Instructions
npm startand start a site. CLI stdout lines should be prefixed with[CLI - <site ID>], and events subscriber lines with[CLI - events].Pre-merge Checklist