Skip to content

Use a neutral CLI log prefix instead of hard-coded 'site ID' - #4108

Merged
gavande1 merged 1 commit into
trunkfrom
fix-cli-log-prefix-label
Jul 8, 2026
Merged

Use a neutral CLI log prefix instead of hard-coded 'site ID'#4108
gavande1 merged 1 commit into
trunkfrom
fix-cli-log-prefix-label

Conversation

@gavande1

@gavande1 gavande1 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Claude wrote the code, guided by the author. The author tested it locally and manually reviewed it before pushing.

Proposed Changes

The stdout echo prefix hard-coded the words "site ID", but logPrefix is also used for non-site contexts. For example, the CLI events subscriber passes "events", which produced the misleading line [CLI - site ID events]. The prefix is now the neutral [CLI - <prefix>], which matches the format CliServerProcess already uses for its own log lines.

Testing Instructions

  • Run npm start and start a site. CLI stdout lines should be prefixed with [CLI - <site ID>], and events subscriber lines with [CLI - events].

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing b9a8990 vs trunk

app-size

Metric trunk b9a8990 Diff Change
App Size (Mac) 1411.96 MB 1411.96 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk b9a8990 Diff Change
load 739 ms 1062 ms +323 ms 🔴 43.7%

site-startup

Metric trunk b9a8990 Diff Change
siteCreation 6493 ms 6501 ms +8 ms ⚪ 0.0%
siteStartup 2379 ms 2393 ms +14 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gavande1
gavande1 requested a review from a team July 7, 2026 13:59

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this change looks good.

trunk this branch
Image Image
@gavande1
gavande1 merged commit a7b912d into trunk Jul 8, 2026
15 checks passed
@gavande1
gavande1 deleted the fix-cli-log-prefix-label branch July 8, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants