Skip to content

Liberate: fix resolving sites as path instead of only real domains - #4110

Merged
nightnei merged 1 commit into
trunkfrom
fixLiberateResolvingDomainsAsPath
Jul 8, 2026
Merged

Liberate: fix resolving sites as path instead of only real domains#4110
nightnei merged 1 commit into
trunkfrom
fixLiberateResolvingDomainsAsPath

Conversation

@nightnei

@nightnei nightnei commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

How AI was used in this PR

The fix was implemented in runtime by Claude Code while liberating the Wix site https://neicss.wixsite.com/sunflower-valley-exp

Output from AI while implementing it:

home=false is suspicious — the homepage should be flagged. Let me check the page list.

  Searched for 2 patterns, read 3 files, listed 1 directory

Without isHome, the theme loses front-page.html and the index fallback shell — worth fixing. Let me see whether the driver can take a page-list override.

  Searched for 3 patterns, read 3 files, ran 1 shell command

Now applying the fix (engine style: 2-space indent, no inner-paren spaces).

The problem with it is - Wix allows having sites as a path under the personal staging domain https://neicss.wixsite.com/<site_kinda_dev_domain_example> so we should parse it too, to determine the home-page.

Testing Instructions

Visual review should suffice

@nightnei
nightnei requested a review from borkweb July 7, 2026 13:00
@nightnei nightnei self-assigned this Jul 7, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing acc1c08 vs trunk

app-size

Metric trunk acc1c08 Diff Change
App Size (Mac) 1411.96 MB 1411.49 MB 0.47 MB ⚪ 0.0%

site-editor

Metric trunk acc1c08 Diff Change
load 761 ms 1098 ms +337 ms 🔴 44.3%

site-startup

Metric trunk acc1c08 Diff Change
siteCreation 6495 ms 6504 ms +9 ms ⚪ 0.0%
siteStartup 2391 ms 2390 ms 1 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@borkweb borkweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@nightnei
nightnei merged commit 3f27709 into trunk Jul 8, 2026
12 checks passed
@nightnei
nightnei deleted the fixLiberateResolvingDomainsAsPath branch July 8, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants