Fix AskUserQuestion to support multiline - #4119
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 30a0264 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
sejas
approved these changes
Jul 8, 2026
sejas
left a comment
sejas
left a comment
Member
There was a problem hiding this comment.
I think it makes sense supporting multiline. Thanks!
katinthehatsite
approved these changes
Jul 9, 2026
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes worked as expected for me 👍
| * description word-wrapped and indented beneath it. Unlike SelectList's | ||
| * built-in single-row layout, nothing is truncated, and embedded newlines in | ||
| * labels and descriptions are preserved. | ||
| */ |
Contributor
There was a problem hiding this comment.
I think the name of the function is pretty self-explanatory so I would remove this or maybe just shorten to mention the gist. Not a strong preference if you find that keeping this is helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI assisted
Proposed Changes
Let's use multiline to avoid trimming label and description in AskUserQuestion
Testing Instructions
npm run cli:buildnode apps/cli/dist/cli/main.mjs code/liberate https://neicss.wixsite.com/sunflower-valley-expUse AskUserQuestion to ask me a question with 3 options and no description"