Skip to content

Fix submit button while editing prompts in Studio Code UI - #4123

Merged
katinthehatsite merged 1 commit into
trunkfrom
fixSubmitForEditingStudioCodeUiPrompt
Jul 9, 2026
Merged

Fix submit button while editing prompts in Studio Code UI#4123
katinthehatsite merged 1 commit into
trunkfrom
fixSubmitForEditingStudioCodeUiPrompt

Conversation

@nightnei

@nightnei nightnei commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1832
Follow up to #4094

How AI was used in this PR

AI assisted

Proposed Changes

In #4094 I menthioned that there is an issue with "Send" button, but I approved the PR so the reported issue was not noticeable enough:
Screenshot 2026-07-08 at 16 07 13

So addressing it here:
Screenshot 2026-07-08 at 16 07 41
Screenshot 2026-07-08 at 16 07 55

Testing Instructions

Visual review should suffice, but JIC:

  1. Navigate to the Studio Code tab and send a message
  2. Pause the message before the AI had a chance to respond
  3. Assert that "Send" button looks good.
@nightnei
nightnei requested review from katinthehatsite and sejas July 8, 2026 15:09
@nightnei nightnei self-assigned this Jul 8, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 2c296b0 vs trunk

app-size

Metric trunk 2c296b0 Diff Change
App Size (Mac) 1412.01 MB 1412.01 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 2c296b0 Diff Change
load 1112 ms 1095 ms 17 ms ⚪ 0.0%

site-startup

Metric trunk 2c296b0 Diff Change
siteCreation 6972 ms 6998 ms +26 ms ⚪ 0.0%
siteStartup 2388 ms 2392 ms +4 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@katinthehatsite

Copy link
Copy Markdown
Contributor

Thanks for fixing this @nightnei ! I mostly use the dark mode so I missed this 🙈

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good and work as expected 👍


.userEditSendButton {
/* Doubled class outweighs Tailwind preflight's `[type='button'] { background-color: transparent }` reset. */
.userEditSendButton.userEditSendButton {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a known pattern so we could probably clean up the comment. Not a big deal though

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will just merge it as is for now

@katinthehatsite
katinthehatsite merged commit 7f8149b into trunk Jul 9, 2026
16 checks passed
@katinthehatsite
katinthehatsite deleted the fixSubmitForEditingStudioCodeUiPrompt branch July 9, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants