Agentic UI: Fix Linux/Windows window controls - #4166
Merged
Conversation
… exact height, live sync
gavande1
marked this pull request as ready for review
July 10, 2026 12:36
Collaborator
📊 Performance Test ResultsComparing 02595e4 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
…indow-controls-agentic-ui
bcotrim
requested changes
Jul 15, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Actually this is breaking legacy UI create site, so it should be addressed now:
| Light | Dark |
|---|---|
 |
 |
…indow-controls-agentic-ui # Conflicts: # apps/studio/src/ipc-handlers.ts
gavande1
force-pushed
the
stu-2030-fix-linux-window-controls-agentic-ui
branch
from
July 16, 2026 09:27
c8e415f to
de511e8
Compare
Contributor
Author
|
@bcotrim fixed the fullscreen modal issue. Do you mind taking another look? |
Contributor
|
The dark colors on the create site screen in legacy UI still look different, do you think we could adjust it? 
|
Contributor
Author
|
@bcotrim updated the fullscreen modal controls to match the frame background color. Do you mind taking another look?
|
bcotrim
approved these changes
Jul 16, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Looks great now, thanks for making the changes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
AI helped locate the window-control code across the main process and both renderers, diagnose the height and color mismatch, and draft the fix. I reviewed the code and verified the behavior by hand in the running Linux app, across light and dark mode and both UI modes.
Proposed Changes
On Windows and Linux, the native window controls (minimize, maximize, close) in the agentic UI overflowed into the site preview and did not follow the theme, so in light mode they showed as an out-of-place dark block.
Now the preview toolbar reserves the exact area the OS reports for the controls, so they no longer spill into the site view, and the controls match the toolbar color in both light and dark mode. The color also stays in sync when you toggle the theme or switch between the classic and agentic UI. The classic UI keeps its existing dark controls, so it is unchanged.
Testing Instructions
Pre-merge Checklist