Skip to content

Agentic UI: Fix agentic UI dark-mode icons and dropdowns - #4168

Merged
gavande1 merged 7 commits into
trunkfrom
stu-2032-dark-mode-icon-fixes
Jul 13, 2026
Merged

Agentic UI: Fix agentic UI dark-mode icons and dropdowns#4168
gavande1 merged 7 commits into
trunkfrom
stu-2032-dark-mode-icon-fixes

Conversation

@gavande1

@gavande1 gavande1 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

AI helped locate the icon and dropdown code in the agentic UI, diagnose why each element did not follow dark mode, and draft the fixes. I reviewed the code and checked the behavior in the running Linux app.

Proposed Changes

Several elements in the agentic UI did not adapt to the color scheme:

  • The account avatar fallback was invisible in both themes: a light icon in light mode and a black icon in dark mode.
  • Native select dropdowns (for example the language and preferred-terminal fields) showed a white option list with unreadable text in dark mode.
  • The envelope icon on the Admin email field rendered near-black in dark mode.

Now all three follow the active theme, so they stay legible in both light and dark mode.

Testing Instructions

  1. In the agentic UI, switch to dark mode.
  2. Open the account menu and confirm the avatar fallback icon is visible.
  3. Open Settings, open the language and preferred-terminal dropdowns, and confirm the option list is dark with readable text.
  4. Open a site's settings and confirm the Admin email envelope icon is visible.
  5. Repeat in light mode to confirm nothing regressed.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@gavande1 gavande1 changed the title Fix agentic UI dark-mode icons and dropdowns Jul 10, 2026
@gavande1
gavande1 marked this pull request as ready for review July 10, 2026 13:11
@gavande1
gavande1 requested review from a team, katinthehatsite and shaunandrews July 10, 2026 13:14
@wpmobilebot

wpmobilebot commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing bfaee23 vs trunk

app-size

Metric trunk bfaee23 Diff Change
App Size (Mac) 1419.48 MB 1419.48 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk bfaee23 Diff Change
load 748 ms 742 ms 6 ms ⚪ 0.0%

site-startup

Metric trunk bfaee23 Diff Change
siteCreation 6497 ms 6473 ms 24 ms ⚪ 0.0%
siteStartup 2393 ms 2395 ms +2 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @gavande1! Changes LGTM and I confirm seeing the dark-version icons now. 👍

For the dropdowns in Settings, I tried to reproduce getting light-themed selects there, but it was working correctly for me with the trunk version as well.

Area Before After
Default avatar Image Image
Site settings Image Image
Settings dropdowns Image Image
@gavande1
gavande1 merged commit 3302d01 into trunk Jul 13, 2026
11 checks passed
@gavande1
gavande1 deleted the stu-2032-dark-mode-icon-fixes branch July 13, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants