Skip to content

Remove envelope icon from admin email field in agentic UI - #4174

Merged
bcotrim merged 1 commit into
trunkfrom
stu-2039-remove-admin-email-icon
Jul 10, 2026
Merged

Remove envelope icon from admin email field in agentic UI#4174
bcotrim merged 1 commit into
trunkfrom
stu-2039-remove-admin-email-icon

Conversation

@shaunandrews

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Written entirely with Claude Code: it traced the icon to the DataViews email edit control, made the change, and verified it in the running local UI (studio ui + dev:local) in both color schemes, including confirming email validation still fires. Screenshots below were captured during that verification.

Proposed Changes

The admin email field in the agentic UI (site creation and site settings) rendered with an envelope icon inside the input. The icon comes from DataViews' built-in email edit control, and it has two problems: it doesn't adapt to dark mode (a dark icon on a dark input, so it reads as a smudge), and it adds nothing — the field is already labeled "Admin email". The field now renders as a plain input, matching every other text field in the form. Email-format validation is unchanged, since it comes from the field's email type rather than the edit control.

Before After
Dark before dark after dark
Light before light after light

(Screenshots live on the throwaway stu-2039-screenshots branch — safe to delete after merge.)

Testing Instructions

  1. Run the agentic UI (e.g. npm start with agentic UI enabled, or npm run dev:local --workspace=apps/ui against studio ui).
  2. Start creating a new site and expand Advanced settings.
  3. Confirm the Admin email input has no envelope icon and looks consistent with the other inputs, in both light and dark mode.
  4. Enter an invalid email (e.g. not-an-email) and confirm the validation error still appears.
  5. Repeat the check in an existing site's Settings view, which shares the same field.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing cc982ad vs trunk

app-size

Metric trunk cc982ad Diff Change
App Size (Mac) 1419.35 MB 1419.35 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk cc982ad Diff Change
load 1080 ms 1083 ms +3 ms ⚪ 0.0%

site-startup

Metric trunk cc982ad Diff Change
siteCreation 7035 ms 6990 ms 45 ms ⚪ 0.0%
siteStartup 2346 ms 2354 ms +8 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Light Dark
Image Image
@bcotrim
bcotrim merged commit c865090 into trunk Jul 10, 2026
12 checks passed
@bcotrim
bcotrim deleted the stu-2039-remove-admin-email-icon branch July 10, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants