Remove envelope icon from admin email field in agentic UI - #4174
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing cc982ad vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issues
How AI was used in this PR
Written entirely with Claude Code: it traced the icon to the DataViews
emailedit control, made the change, and verified it in the running local UI (studio ui+dev:local) in both color schemes, including confirming email validation still fires. Screenshots below were captured during that verification.Proposed Changes
The admin email field in the agentic UI (site creation and site settings) rendered with an envelope icon inside the input. The icon comes from DataViews' built-in
emailedit control, and it has two problems: it doesn't adapt to dark mode (a dark icon on a dark input, so it reads as a smudge), and it adds nothing — the field is already labeled "Admin email". The field now renders as a plain input, matching every other text field in the form. Email-format validation is unchanged, since it comes from the field'semailtype rather than the edit control.(Screenshots live on the throwaway
stu-2039-screenshotsbranch — safe to delete after merge.)Testing Instructions
npm startwith agentic UI enabled, ornpm run dev:local --workspace=apps/uiagainststudio ui).not-an-email) and confirm the validation error still appears.Pre-merge Checklist