Fix IPC sender validation error when toggling the Agentic UI feature flag - #4200
Merged
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing c7e5368 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
katinthehatsite
approved these changes
Jul 15, 2026
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
Nice, I don't see the error anymore 👍
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code traced the console error to its root cause and authored the fix; the change was reviewed and verified locally (lint, typecheck, unit tests).
Proposed Changes
Toggling the "Enable Agentic UI" feature flag logged a
Failed IPC sender validation checkerror (surfacing asError occurred in handler for 'getAppGlobals') on every toggle.When a UI-mode flag flips, the main window reloads into the other renderer and the allowed IPC origin switches immediately — but we also sent
refresh-app-globalsto the outgoing renderer, whose resultinggetAppGlobalscall then failed sender validation. The refresh is pointless for a page that's being replaced (the new renderer fetches fresh globals on boot), so we now skip it when the toggle triggers a renderer reload. Other feature-flag toggles still refresh app globals as before.The error was benign (it came from the renderer being torn down), so this is a log-noise fix with no user-facing behavior change beyond cleaner consoles.
Testing Instructions
npm start.Error: Failed IPC sender validation check: http://localhost:5173/on each toggle; now it doesn't.Pre-merge Checklist
🤖 Generated with Claude Code