Clarify PHP runtime translator comments for Native/Sandbox labels - #4234
Merged
Conversation
The Native/Sandbox labels reach translators without indicating they are a paired PHP runtime choice, making it hard to pick wording that reads as the intended contrast. Rewrite the translator comments to state the pairing and what each option does. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing 9c246d6 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
| value={ selectedRuntime } | ||
| options={ [ | ||
| /* translators: As in an application that runs natively on a computer */ | ||
| /* translators: PHP runtime option, paired with "Sandbox". The compiled PHP binary Studio bundles and runs natively on the machine. */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /* translators: PHP runtime option, paired with "Sandbox". The compiled PHP binary Studio bundles and runs natively on the machine. */ | |
| /* translators: PHP runtime option, paired with "Sandbox". The compiled PHP binary that Studio bundles and runs natively on the machine. */ |
katinthehatsite
approved these changes
Jul 17, 2026
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes look good, I left one minor comment. The sentence itself is okay but it might be easier to read for non-native speakers who are doing these translations
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Used Claude Code to locate every place the "Native"/"Sandbox" runtime labels are exposed to translators and to rewrite the translator comments consistently. The reasoning and final wording were reviewed by a human.
Proposed Changes
The PHP runtime setting offers a choice between "Native" and "Sandbox". I propose updating translator comments to provide more context for those short phrases, to make it easier for translators to learn about the context.
Testing Instructions
Pre-merge Checklist