Update @yao-pkg/pkg to 6.21.0 to resolve esbuild security alert - #4242
Merged
Conversation
Bumps @yao-pkg/pkg from 6.14.1 to 6.21.0, which requires esbuild ^0.28.1 and removes the vulnerable esbuild 0.27.x (Dependabot alert #232). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
📊 Performance Test ResultsComparing b0a6cdc vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Used Claude Code to trace the alert to its transitive source, bump the dependency, refresh the lockfile, and verify the vulnerable version was fully removed (dedupe check +
npm audit+ typecheck).Proposed Changes
Dependabot alert #232 is a low-severity esbuild vulnerability (arbitrary file read via the dev server on Windows) affecting
esbuild >= 0.27.3, < 0.28.1. esbuild was pulled in transitively by@yao-pkg/pkg, which pinnedesbuild@^0.27.3.This bumps
@yao-pkg/pkgfrom 6.14.1 to 6.21.0. The newer release requiresesbuild@^0.28.1, so the vulnerable range is gone and the tree resolves to esbuild 0.28.1. As a side effect the newer package dedupes a previously duplicated esbuild platform-binary tree, shrinking the lockfile.No user-visible behavior change —
@yao-pkg/pkgis a devDependency used only to compile the Windows CLI launcher into a standalone.exeduring packaging (apps/studio/forge.config.ts). TheexecAPI it relies on is unchanged.Testing Instructions
npm installresolves esbuild to0.28.1with no remaining0.27.xcopy.npm auditreports no esbuild vulnerability.npm run typecheckpasses across all packages.@yao-pkg/pkg'sexecAPI used inforge.config.tsis unchanged; the standalone CLI.exepackaging path (npm run makeon Windows) is exercised only on Windows/CI and should be confirmed green there.Pre-merge Checklist