Skip to content

Add Keyboard shortcuts tab to agentic UI settings - #4277

Merged
bcotrim merged 8 commits into
trunkfrom
agentic-settings-keyboard-tab
Jul 22, 2026
Merged

Add Keyboard shortcuts tab to agentic UI settings#4277
bcotrim merged 8 commits into
trunkfrom
agentic-settings-keyboard-tab

Conversation

@bcotrim

@bcotrim bcotrim commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

Built with AI, manually reviewed and test by me.

Proposed Changes

Adds Keyboard tab in settings

Light Dark
image image

Testing Instructions

  1. Run the app with the agentic UI enabled and open Settings (⌘,).
  2. Switch to the new Keyboard tab: it should list the General, Composer, and Site preview sections with key chips.
  3. Confirm the listed shortcuts match reality (e.g. ⌘⇧B toggles the site preview, ↩ sends a composer message).
  4. In the site preview, navigate a couple of pages, then press ⌘← / ⌘→ (macOS): the preview should go back/forward — both with focus in the host toolbar and with focus inside the previewed page. ⌘[/⌘] should still work too.
  5. Click into a text field inside the previewed page (e.g. a wp-admin editor) and press ⌘←: the caret should move, not the navigation.
  6. Check the tab in both light and dark mode.
  7. npm test -- apps/ui passes.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

🤖 Generated with Claude Code

@wpmobilebot

wpmobilebot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 86720eb vs trunk

app-size

Metric trunk 86720eb Diff Change
App Size (Mac) 1361.90 MB 1361.93 MB +0.03 MB ⚪ 0.0%

site-editor

Metric trunk 86720eb Diff Change
load 1070 ms 1076 ms +6 ms ⚪ 0.0%

site-startup

Metric trunk 86720eb Diff Change
siteCreation 6989 ms 7009 ms +20 ms ⚪ 0.0%
siteStartup 2353 ms 2352 ms 1 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@bcotrim
bcotrim marked this pull request as draft July 21, 2026 11:19
@bcotrim
bcotrim marked this pull request as ready for review July 21, 2026 12:23
@bcotrim
bcotrim requested review from nightnei and sejas July 21, 2026 12:24
bcotrim added 4 commits July 21, 2026 13:25
…board-tab

# Conflicts:
#	apps/ui/src/components/settings-view/index.tsx
…board-tab

# Conflicts:
#	apps/ui/src/components/settings-view/index.test.tsx
#	apps/ui/src/components/settings-view/style.module.css
…board-tab

# Conflicts:
#	apps/ui/src/components/settings-view/index.tsx
…board-tab

# Conflicts:
#	apps/ui/src/components/settings-view/index.tsx

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. We could also add cmd+n in Composer to start a new conversation.

I tested all the shortcuts on MacOS.

Image
shortcuts: [ { label: __( 'Open settings' ), keys: [ modifierKey, ',' ] } ],
},
{
title: __( 'Composer' ),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer is not really intuitive for me, although we can educate users and I don't have better alternatives.

@bcotrim
bcotrim enabled auto-merge (squash) July 22, 2026 10:22
@bcotrim
bcotrim merged commit 4f33e13 into trunk Jul 22, 2026
13 checks passed
@bcotrim
bcotrim deleted the agentic-settings-keyboard-tab branch July 22, 2026 10:43
@bcotrim bcotrim mentioned this pull request Jul 24, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants